Conversation
wlggraham
approved these changes
Feb 23, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Heimdall jobs table schema to support larger job_context payloads so autogenerated SQL for wide tables fits without truncation/errors.
Changes:
- Adds an idempotent migration block to expand
jobs.job_contexttoVARCHAR(131070)when the current length is smaller. - Separates the existing
cancelled_bycleanupDO $$block from the newjob_contextmigration by closing the first block explicitly.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+34
to
+37
| do $$ begin | ||
| if exists (select 1 from information_schema.columns where table_name = 'jobs' and column_name = 'job_context' and character_maximum_length < 131070) then | ||
| alter table jobs alter column job_context TYPE VARCHAR(131070); | ||
| end if; |
There was a problem hiding this comment.
The create table statement still declares job_context as varchar(65535), but this new migration expands it to varchar(131070). Consider updating the create table column definition (and/or adding a short rationale comment here) so the file reflects the intended final schema and avoids an extra ALTER TABLE on fresh installs.
sanketjadhavSF
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increases the field length for the job_context column to accommodate autogenerated SQL for wide tables.
Testing
Run on local machine
