add factorial and modulo and fix .gitignore#2
Open
aoieop wants to merge 7 commits intopatrickjonesuk:masterfrom
Open
add factorial and modulo and fix .gitignore#2aoieop wants to merge 7 commits intopatrickjonesuk:masterfrom
aoieop wants to merge 7 commits intopatrickjonesuk:masterfrom
Conversation
patrickjonesuk
requested changes
Apr 6, 2021
Owner
patrickjonesuk
left a comment
patrickjonesuk
left a comment
There was a problem hiding this comment.
Please fix these errors so that I can test this.
| return result | ||
|
|
||
| def _multiplication_division(self): | ||
| def _multiplication_division_modulo(self): |
Owner
There was a problem hiding this comment.
You have renamed this function but not renamed its usages.
| result = RootNode(result, self._literal_polarity()) | ||
| elif self._token.type == TokenType.FACTORIAL_OPERATOR: | ||
| self._iterate_token() | ||
| result = RootNode(result, self._literal_polarity) |
| result = RootNode(result, self._literal_polarity()) | ||
| elif self._token.type == TokenType.FACTORIAL_OPERATOR: | ||
| self._iterate_token() | ||
| result = RootNode(result, self._literal_polarity) |
Owner
There was a problem hiding this comment.
You need to call the function, not reference it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.