Conversation
CLA signatures confirmedAll contributors have signed the Contributor License Agreement. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #555 +/- ##
==========================================
+ Coverage 76.95% 77.14% +0.18%
==========================================
Files 32 32
Lines 4409 4450 +41
Branches 730 735 +5
==========================================
+ Hits 3393 3433 +40
+ Misses 716 714 -2
- Partials 300 303 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9b11ec5 to
8cde6f2
Compare
…utputPathReference Generalizes file references to accept any existing filesystem path (file or directory). Removes the is_file() constraint from input validation; existence check is preserved. Output validator is unchanged.
Benchmark ResultsBenchmarks use a no-op Tesseract to measure pure framework overhead. 🚀 0 faster, ✅ No significant performance changes detected. Full results
|
8cde6f2 to
1b804e4
Compare
|
Should we not keep InputFileReference for backwards compatibility? |
d3737ac to
a11ef26
Compare
*DirectoryReferences and enforce is_file() in OutputFileReference
jpbrodrick89
left a comment
There was a problem hiding this comment.
Cool, I like this, I'd approve but as it's still draft I will wait until you mark it ready until I give the full green light. Thanks!
48111c6 to
5d05532
Compare
5d05532 to
e63438c
Compare
Yes, this was still quite drafty. After a chat with @xalelax I now settled on |
*DirectoryReferences and enforce is_file() in OutputFileReference…-core into nh/path-references
dionhaefner
left a comment
There was a problem hiding this comment.
Approved while we decide what to do with #569
Alternative design for #304
*PathReferences in apply schemasInputPath / OutputPath schemas
InputPath / OutputPath schemasInputPath / OutputPath types to tesseract_core.runtime.experimental
InputPath / OutputPath types to tesseract_core.runtime.experimentalInputPath / OutputPath types to tesseract_core.runtime.experimental, deprecate InputFileReference + OutputFileReference
Description of changes
InputPath/OutputPathto support both files and directories (previously file-only). The old*FileReferencenames still work but emit aDeprecationWarning.examples/file_io/— replaces the oldfilereferenceexampleTesting done
tesseract_core/runtime/testing/regression.py—TestSpecgainsskip_output_path_checksflag so test cases with*PathReferenceoutputs can skip output schema validation. OtherwiseOutputSchematries to validate files that are not there yet.tests/endtoend_tests/test_examples.py— updated to use atmp_pathoutput directory for the path-reference example (avoids polluting the example tree).