doc: document how to use tesseract serve --network parameter#530
doc: document how to use tesseract serve --network parameter#530dionhaefner merged 10 commits intomainfrom
tesseract serve --network parameter#530Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #530 +/- ##
===========================================
- Coverage 76.95% 66.77% -10.19%
===========================================
Files 32 32
Lines 4409 4409
Branches 730 730
===========================================
- Hits 3393 2944 -449
- Misses 716 1226 +510
+ Partials 300 239 -61 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks @zmheiko ! Do you think we should pull the trigger and also create networks passed with |
The only drawback that I'm seeing is that the user might pass a wrong network name (e.g. XXY), misses the emitted "new network XXY created" message (that I assume we'd add), and then wonders why the new Tesseract cannot communicate with the existing ones in network XXX. So maybe an additional |
tesseract serve --network parameter
|
I updated the documentation and added a Ping-Tesseract that can be used to check if networking works. I tested it on Mac (with Colima, but this should behave the same way as Docker Desktop) and a Azure Linux VM (with Docker Engine). As expected, with |
|
#544 tackles automatic network creation. Let's revisit the doc changes after, as you suggested @dionhaefner. |
…it does not exist (#544) #### Relevant issue or PR #530 documents how to use the `--network` option and needs updating once this PR is merged. #### Description of changes When `--network <name>` is passed to `tesseract serve` or `tesseract run` and no network with that name exists, we now automatically create it instead of failing with a Docker error. #### Testing done Tested that multi-Tesseract hello world example works without explicit network creation. --------- Co-authored-by: Dion Häfner <dion.haefner@simulation.science>
|
Done, @zmheiko do your thang |
This addresses the lack of documentation around network usage and some of its pitfalls.
Relevant issue or PR
This acts as a stopgap for #410. Moving forward, more tooling around network usage is needed.
Description of changes
Add documentation