Fix: pass stream error to next and call destroyAndRestore() in second…#207
Merged
papandreou merged 1 commit intopapandreou:masterfrom Apr 30, 2026
Merged
Fix: pass stream error to next and call destroyAndRestore() in second…#207papandreou merged 1 commit intopapandreou:masterfrom
papandreou merged 1 commit intopapandreou:masterfrom
Conversation
…GuessSourceContentType error handling
Contributor
Author
|
@papandreou thank you, the checks are working now. |
papandreou
approved these changes
Apr 30, 2026
Owner
|
Released in 11.2.1. The test looks bit crazy though 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix error handling in secondGuessSourceContentType stream listener
When a stream emits an error before the first data chunk, the error handler was calling next(500) — passing a hardcoded status code instead of the actual error, and skipping the
destroyAndRestore() cleanup call.
This fix passes the real error to next(err) and calls destroyAndRestore() first to properly clean up the stream before handing off to the error handler.