Skip to content

Button that links remotes#2

Open
eliaspinero wants to merge 12 commits intomainfrom
eliaspinero/fix-pull
Open

Button that links remotes#2
eliaspinero wants to merge 12 commits intomainfrom
eliaspinero/fix-pull

Conversation

@eliaspinero
Copy link
Copy Markdown

This PR addresses issue #1

Did this PR on the right repo this time

@eliaspinero eliaspinero requested a review from mvahowe October 21, 2025 14:55
@eliaspinero eliaspinero changed the title Eliaspinero/fix pull Button that links remotes Oct 21, 2025
Copy link
Copy Markdown

@mvahowe mvahowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the button works. I created a local project LMTT, pushed it and pulled it, resulting in this:

$ ls pankosmia_repos/git.door43.org/BurritoTruck/
en_bsb  en_fiaimages  en_sq  fr_lsga  fr_vp  LMTT  MT  my_bcl
$ ls pankosmia_repos/_local_/_local_
LMTT  MT

but the "connect" button remains disabled.

Also:

  • there are a lot of unused imports and variables
  • please remove commented code. This time it caused a merge conflict that took three commits to fix
  • the appbar should be "secondary" - see other dialogs that Loïse has tidied up.

@mvahowe
Copy link
Copy Markdown

mvahowe commented Dec 10, 2025

@eliaspinero I think this is one place where we got stuck because the git pull operation was throwing an error with Windows (even though it seems like the actual pull happens). The latest desktop-app-pithekos can compile a debug version of the server. (You need to add -d to build_server and then to run. I'm hoping we'll see more output in the server console. (It may be one or a few words, I put in about 50 different messages for each point where things might fail.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants