Proposed config file changes for "project spec v1"#335
Closed
ksikka wants to merge 1 commit intopaninski-lab:mainfrom
Closed
Proposed config file changes for "project spec v1"#335ksikka wants to merge 1 commit intopaninski-lab:mainfrom
ksikka wants to merge 1 commit intopaninski-lab:mainfrom
Conversation
d84d50a to
7aa1bb8
Compare
Collaborator
Author
|
closing as cleanup. the ideas within can be documented in idea docs and reimplemented with claude code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The context is aligning app / CLI directory structure.
To summarize the major changes:
csv_path) or video directory (videos_dir).TXTfile of unsupervised training sessions.CSVfiles that override default Session -> calibration and bbox mapping.data_dir.data_dirremains an absolute path, but I plan to make it overrideable at runtime.Field Mapping
videos_dirunsup_sessions_listdata_dir/videoscsv_filelabel_file_keybbox_fileuse_bboxesANDsession_bbox_filecamera_params_filesession_calibration_fileThe new fields are described in their config file comments
This design is more flexible than my original proposal; it allows overriding default locations of calibration files and bboxes.
Added these doc sections which describe this PR's proposal.
calibrations: https://docs.google.com/document/d/1H9OCIRxlA5JggStAVtLR9RoW358I9ESojLeaepKqcsA/edit?disco=AAABuJdUFkM
bboxes: https://docs.google.com/document/d/1H9OCIRxlA5JggStAVtLR9RoW358I9ESojLeaepKqcsA/edit?disco=AAABuJdUFkg