Open
Conversation
Adding the draft status to signals allows to ignore pull requests for
auto-merge if they are in draft status.
Example:
```yaml
merge:
ignore:
draft:true
```
Member
|
Thanks for your interest in palantir/bulldozer, @blang! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
Contributor
|
Thanks for adding this! As a signal, this implementation looks good, but I don't think a signal/option is necessary. My understanding is that GitHub does not allow merging draft pull requests, so it should be safe for Bulldozer to always ignore draft PRs when processing merges. |
Author
|
Currently only tested this with github enterprise 3.3.1 which actually resulted in the PR to be merged despite being in draft state. I was thinking the same but definitely verified this behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the draft status to signals allows to ignore pull requests for
auto-merge if they are in draft status.
Example: