Skip to content

Add storage account module diagram in README.md#1086

Merged
Krusty93 merged 9 commits intomainfrom
storage-account-chart
Mar 18, 2026
Merged

Add storage account module diagram in README.md#1086
Krusty93 merged 9 commits intomainfrom
storage-account-chart

Conversation

@Krusty93
Copy link
Copy Markdown
Contributor

@Krusty93 Krusty93 commented Nov 20, 2025

This PR adds a mermaid diagram representing the architecture of Storage Account Terraform module.

NOTE: icons are not rendered on GitHub, neither the Terraform Registry. Currently working for a solution

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Nov 20, 2025

🦋 Changeset detected

Latest commit: cc1f5f5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
azure_storage_account Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Krusty93 Krusty93 marked this pull request as ready for review November 20, 2025 10:53
@Krusty93 Krusty93 requested a review from a team as a code owner November 20, 2025 10:54
Comment thread infra/modules/azure_storage_account/README.md Outdated
@Krusty93 Krusty93 changed the title Ddd storage account module diagram in README.md Add storage account module diagram in README.md Nov 20, 2025
@Krusty93 Krusty93 marked this pull request as draft November 20, 2025 11:11
@Krusty93 Krusty93 force-pushed the storage-account-chart branch from 06c9b78 to ee70510 Compare November 24, 2025 11:31
@Krusty93 Krusty93 force-pushed the storage-account-chart branch from 71a3373 to 830b3f8 Compare March 13, 2026 17:15
@Krusty93 Krusty93 marked this pull request as ready for review March 13, 2026 17:21
@gunzip gunzip requested review from Copilot and gunzip March 17, 2026 20:39
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds an architecture diagram for the azure_storage_account Terraform module, including the Mermaid source and a generated SVG rendered in the module README.

Changes:

  • Add diagram.mmd (Mermaid source) for the module architecture.
  • Add diagram.svg (generated output) and embed it in the module README.md.
  • Add a Changesets entry to publish a patch release for the module documentation update.

Reviewed changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated 2 comments.

File Description
infra/modules/azure_storage_account/diagram.svg Adds the generated SVG diagram asset.
infra/modules/azure_storage_account/diagram.mmd Adds the Mermaid source used to generate the SVG diagram.
infra/modules/azure_storage_account/README.md Embeds the diagram image in the module documentation.
.changeset/eight-years-dress.md Records a patch release note for adding the diagram.

Comment thread infra/modules/azure_storage_account/README.md
Comment thread .changeset/eight-years-dress.md Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@Krusty93 Krusty93 merged commit 9294e5e into main Mar 18, 2026
9 checks passed
@Krusty93 Krusty93 deleted the storage-account-chart branch March 18, 2026 13:34
@github-actions
Copy link
Copy Markdown
Contributor

📋 Pre-commit Output Log
[INFO] Initializing environment for https://github.com/antonbabenko/pre-commit-terraform.
An unexpected error has occurred: CalledProcessError: command: ('/usr/bin/git', 'diff', '--name-only', '--no-ext-diff', '-z', 'origin/main..origin/storage-account-chart')
return code: 128
stdout: (none)
stderr:
    fatal: ambiguous argument 'origin/main..origin/storage-account-chart': unknown revision or path not in the working tree.
    Use '--' to separate paths from revisions, like this:
    'git <command> [<revision>...] -- [<file>...]'
Check the log at /github/home/.cache/pre-commit/pre-commit.log

Generated on Wed Mar 18 13:34:49 UTC 2026
Run all checks on modified files

christian-calabrese pushed a commit that referenced this pull request Mar 30, 2026
Co-authored-by: dx-pagopa-bot <dx-pagopa-github-bot@pagopa.it>
Co-authored-by: Danilo Spinelli <gunzip@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants