Skip to content

Add z-stream search tool for finding commits for older z-streams#387

Merged
TomasTomecek merged 1 commit intopackit:mainfrom
antbob:6_zstream_search
Mar 16, 2026
Merged

Add z-stream search tool for finding commits for older z-streams#387
TomasTomecek merged 1 commit intopackit:mainfrom
antbob:6_zstream_search

Conversation

@antbob
Copy link
Copy Markdown
Contributor

@antbob antbob commented Mar 10, 2026

To locate the most appropriate (closest to the current stream) patch to backport for older RHEL z-streams this new tool allows the agent to search all relevant Jira issues for a patch by proximity to the current stream and extract patch link/s from the Jira Development section which contains relevant commits. This gives the agent a better chance of backport success and also ensures no regressions are introduced by backporting the upstream or y-stream patches directly in cases where z-stream specific patch changes are made in between.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new ZStreamSearchTool designed to find commits for older RHEL z-streams by searching related Jira issues. While the implementation includes comprehensive tests and sound logic, there is a potential JQL injection vulnerability. User-supplied input for the component name is directly concatenated into the JQL string without proper escaping, which could allow an attacker to manipulate the search query. It is recommended to escape this input to mitigate the risk.

Comment thread agents/tools/zstream_search.py
@antbob antbob force-pushed the 6_zstream_search branch from 5bfc7d2 to 12729a7 Compare March 11, 2026 11:48
@antbob antbob force-pushed the 6_zstream_search branch from 12729a7 to 332bb59 Compare March 12, 2026 08:46
Copy link
Copy Markdown
Member

@TomasTomecek TomasTomecek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty straightforward and has nice test coverage, LGTM

@TomasTomecek TomasTomecek merged commit 49c8487 into packit:main Mar 16, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants