Add prep_sources MCP tool and Kerberize download_sources MCP tool#386
Merged
TomasTomecek merged 1 commit intopackit:mainfrom Mar 16, 2026
Merged
Add prep_sources MCP tool and Kerberize download_sources MCP tool#386TomasTomecek merged 1 commit intopackit:mainfrom
TomasTomecek merged 1 commit intopackit:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new prep_sources MCP tool and adds Kerberos authentication support to the download_sources tool. The changes include refactoring command creation into a helper function and adding a helper to attempt Kerberos initialization while gracefully handling failures. The implementation looks good, and the new functionality is covered by unit tests. My main feedback is to improve error handling by capturing and reporting the stdout/stderr from subprocess calls, which will significantly aid in debugging failures.
Note: Security Review did not run due to the size of the PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rhpkg tool requires authentication even for basic operations like downloading sources and package prep. This commit adds a new prep_sources MCP tool and updates download_sources MCP tool to use Kerberos. If Kerberos auth is unavailable or fails the logic is to log a warning and continue so this should not change the existing behavior and should work for both rhpkg and centpkg tools.