Migration setup for database#294
Merged
Merged
Conversation
- db exists -> migration table exists -> run migrate - db exists -> migration table does not exist -> create migration table -> run migrate - db does not exist -> run migrate
This comment was marked as resolved.
This comment was marked as resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are in need for a bit of a database migration setup 🙃 Should simplify future feature additions and changes, especially since new beets versions might require us to refactor our database state serialization logic.
This PR adds Alembic as a dependency and creates a minimal setup that runs migrations whenever the container is started. This should be enough for our current use case.
Changes
To review it might be helpful to check singular commits in order. They should be pretty digestible.