-
Notifications
You must be signed in to change notification settings - Fork 28
fix: normalize artist timestamp units for New additions #291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
bd832ae
fix: normalize artist timestamp units in library browse (fixes #289)
saschabuehrle f8e1e2e
docs(changelog): add unreleased note for timestamp fix (#289)
saschabuehrle 499bee1
refactor: reuse shared date parsing helper for artist timestamps
saschabuehrle bde05c7
fix(types): resolve mypy assignment/overload errors in session.py
saschabuehrle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,24 @@ | ||
| export const parseApiDate = (value: unknown): Date | undefined => { | ||
| if (value === null || value === undefined) { | ||
| return undefined; | ||
| } | ||
|
|
||
| const numeric = typeof value === 'number' ? value : Number(value); | ||
| if (!Number.isNaN(numeric)) { | ||
| // Some API responses provide UNIX seconds while others use milliseconds. | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do you know which endpoints return UNIX seconds and which return milliseconds? It might be cleaner to fix this inconsistency in the backend instead of a workaround in the frontend. |
||
| const timestamp = numeric < 1e12 ? numeric * 1000 : numeric; | ||
| const date = new Date(timestamp); | ||
| return Number.isNaN(date.getTime()) ? undefined : date; | ||
| } | ||
|
|
||
| if (typeof value === 'string') { | ||
| const date = new Date(value); | ||
| return Number.isNaN(date.getTime()) ? undefined : date; | ||
| } | ||
|
|
||
| return undefined; | ||
| }; | ||
|
|
||
| export const relativeTime = (date?: Date | null) => { | ||
| if (!date) return 'never'; | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to use 1.2.2 here already.
As an fyi:
We are mainly developing on the
releases/2.0.0branch at the moment (latestdocker tag).Since this is a minor fix tho let's include it in the stable version based on
maintoo. I gona rebase or merge the changes into the release branch once they hit main 👍