Conversation
Contributor
|
Should we be installing nng [1] instead of the current nanomsg, too? |
fruffy
added
the
breaking-change
Signed-off-by: fruffy <fruffy@nyu.edu>
Signed-off-by: fruffy <fruffy@nyu.edu>
fruffy
force-pushed
the
fruffy/nnpy_deprecation
branch
from
f6125eb to
9acc6a1
Compare
Contributor
Author
It's a pretty large change and the Python dep is meant to be backwards compatible. Can do it in a separate PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nnpy has been deprecated four years ago and shows signs of bit-rotting. Installing it on newer distributions seems to cause issues. This is a draft to replace nnpy with pynng.
The reason nanomsg is very useful is because it allows us to model network switch behavior without requiring veths. And without veths we do not need sudo. When working with agents, a tight feedback loop can be useful, which includes running packet tests. sudo requirements can get in the way of that.
Related PRs: #p4lang/ptf#234 p4lang/p4c#5576