Reject snapshot requests when read-only#1914
Merged
jmpesp merged 1 commit intooxidecomputer:mainfrom Mar 23, 2026
Merged
Conversation
The root of the problem behind oxidecomputer/omicron#9855 was that the downstairs was retrying an job that would never succeed, and notifying the upstairs every time it failed in a hot loop. This consumed memory until it was entirely exhausted. Fix this by rejecting snapshot requests when read-only in the Upstairs. Note we don't need to check this in Volume because each Upstairs in a Volume should be read-only if any of them are. Fixes oxidecomputer#1856
leftwo
approved these changes
Mar 23, 2026
| */ | ||
|
|
||
| if snapshot_details.is_some() { | ||
| if self.cfg.read_only { |
Contributor
There was a problem hiding this comment.
Do we expect to be calling this if things are behaving as expected?
If yes, then maybe we don't want to log it.
If it's not expected, then it's fine to leave the log.
Contributor
Author
There was a problem hiding this comment.
It's definitely not expected - if anything it'd be great to package this up as a fault soemhow (aka oxidecomputer/omicron#10118)
Contributor
There was a problem hiding this comment.
Yeah, we should start making a list of these places in crucible where we want to tell someone about it, but don't know how to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The root of the problem behind oxidecomputer/omicron#9855 was that the downstairs was retrying an job that would never succeed, and notifying the upstairs every time it failed in a hot loop. This consumed memory until it was entirely exhausted.
Fix this by rejecting snapshot requests when read-only in the Upstairs. Note we don't need to check this in Volume because each Upstairs in a Volume should be read-only if any of them are.
Fixes #1856