Draft
Conversation
Added an option to crucible-verify-raw that will produce csv output instead of a formatted print. This will allow easier post processing of the output and ease comparing output from different extent files.
Add a dirty column (reflecting the extent's dirty bit) to each row of the CSV output. Replace the redundant slot_a_selected/slot_b_selected columns with a single selected_slot column: true means slot A is selected, false means slot B, unknown when the extent is dirty.
Read the slot selection bitmap unconditionally, even when the dirty bit is set. The selected_slot column now always shows true/false instead of "unknown". Post-processing tools can use the dirty column to decide whether to trust the slot selection value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an option to crucible-verify-raw that will produce csv output instead of a formatted print.
This will allow easier post processing of the output and ease comparing output from different extent files.
Example output:
I'm building some other tools to compare output from crucible-verify-raw, but moving to csv first will make that whole process easier.