feat(login): fixed permission for ovh.conf in login#185
Merged
Conversation
Signed-off-by: olivier dubo <olivier.dubo@ovhcloud.com>
amstuta
reviewed
May 11, 2026
| } | ||
| } | ||
|
|
||
| if err := os.Chmod(flags.CliConfigPath, 0600); err != nil { |
Collaborator
There was a problem hiding this comment.
we should modify the file permissions only if we're creating it, not if the file already exists. I think the best option would be a defer func to do this chmod at the end of the if block that begins on line 39.
Signed-off-by: olivier dubo <olivier.dubo@ovhcloud.com>
Signed-off-by: olivier dubo <olivier.dubo@ovhcloud.com>
amstuta
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fixed permission for ovh.conf in login
Fixes #178 (issue)
Type of change
Please delete options that are not relevant.
Checklist:
go mod tidy