This repository was archived by the owner on Apr 20, 2019. It is now read-only.
Inject credentials from batch endpoint if applicable#87
Open
alphapseudo wants to merge 2 commits intooutmoded:masterfrom
Open
Inject credentials from batch endpoint if applicable#87alphapseudo wants to merge 2 commits intooutmoded:masterfrom
alphapseudo wants to merge 2 commits intooutmoded:masterfrom
Conversation
cadecairos
suggested changes
Sep 13, 2018
Contributor
cadecairos
left a comment
There was a problem hiding this comment.
Hi @alphapseudo, Thanks for submitting this pull request!
Before this can get merged, can you please write a unit test for this change?
Contributor
|
@cadecairos looks like @alphapseudo moved on. Either finish the work yourself or close the issue. |
b08cb1c to
fb9da91
Compare
Author
|
@cadecairos sorry about the delay, I added a test in fb9da91 |
Contributor
|
@cadecairos Can we bring this to a conclusion? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request serves as an optimization for batch requests that require authentication.
Expected Result:
If the batch endpoint requires authentication, it should re-use those credentials for any of the subsequent injected requests. In other words, it should only check the session storage once for all the requests in a batch.
Actual Result:
The subsequent requests ignore the initial credential validation and performs a session lookup for the n requests.
Reproduction Steps: