Fix OpenMP 6.0 taskgraph/target clause parsing and graph_reset payload#46
Merged
Merged
Conversation
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR rebases the OpenMP 6.0 fixes onto the latest
origin/mainand addresses parser/IR root causes uncovered by OpenMP_VV 6.0 coverage.Root Cause
OpenMP 6.0 syntax was partially parsed but not fully modeled in clause construction paths:
taskgraph nogroupwas not accepted intaskgraph_clause.graph_reset(expr)was not accepted (only baregraph_reset).target ... shared(...)used in taskgraph-target cases was rejected.OpenMPDirective::addOpenMPClause, causing null clause objects and parser instability.graph_resetstringification dropped optional expression payload.Changes
src/ompparser.yygraph_reset:graph_resetgraph_reset(<expression>)nogroup_clausetotaskgraph_clause.shared_clausetotarget_clause.src/OpenMPIR.cppOpenMPDirective::addOpenMPClausefor:OMPC_graph_idOMPC_graph_resetOMPC_replayableOMPC_memscopeOpenMPGraphResetClause::toString()to preserve optional expression payload:graph_resetorgraph_reset(expr)as appropriate.Validation
Built and tested after rebasing onto latest
origin/main:Result: 1526/1526 tests passed.
Notes
This keeps behavior in the parser/IR layer (no output masking/workarounds) and aligns OpenMP 6.0 taskgraph/target clause acceptance with OpenMP_VV usage.