Codebase Improvements and Cleanup#43
Conversation
- Remove trimWhitespaceCopy wrapper function - Replace 9 call sites with trimWhitespace - Uses more complete whitespace char set (form feed, vertical tab) - Add trimWhitespace overload taking pos/count to avoid substring copies - Remove redundant check in trimWhitespace overload
- Add check for pos >= text.size() to prevent out_of_range exception - Add overflow check for pos + count calculation (end_pos < pos) - Ensures robust handling of edge cases
|
@codex review |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 63bfefc2da
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Codebase improvements and cleanup
This PR contains several small improvements to the ompparser codebase:
tmp_*.pragmasfiles from repository rootchecktarget to CMake: Added a convenientchecktarget that runsctest --output-on-failureusing namespace std;from public header file (OpenMPIR.h) and qualified all standard library types withstd::All 1525 tests pass after these changes!