Make clause payloads separator-aware and keep clause occurrences#13
Conversation
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
5845f06 to
1e482bb
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| void addVar(const std::string &expr, | ||
| OpenACCClauseSeparator sep = ACCC_CLAUSE_SEP_comma) { | ||
| vars.push_back(OpenACCExpressionItem{expr, sep}); | ||
| } |
There was a problem hiding this comment.
Deduplicate var-list entries when merging clauses
When clause merging is enabled, var-list clauses are still fed through the addVar(const std::string&, …) overload, which at lines 118‑121 just appends each item and never checks for duplicates. In merging mode the parser reuses the first clause instance (e.g., two copy(a) clauses end up calling this overload twice on the same object), so the normalized output now becomes copy(a, a) instead of the previously deduped copy(a). This regresses the merge/normalization behavior even when OpenACCDirective::setClauseMerging(true) is set.
Useful? React with 👍 / 👎.
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Testing