This repository was archived by the owner on Jul 16, 2021. It is now read-only.
Fix argument passing for python-telegram-bot>=12.0#7
Open
odel4y wants to merge 4 commits intoosir:masterfrom
Open
Fix argument passing for python-telegram-bot>=12.0#7odel4y wants to merge 4 commits intoosir:masterfrom
odel4y wants to merge 4 commits intoosir:masterfrom
Conversation
This was referenced Dec 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
Thanks for this nifty script! However the current code fails with newer python-telegram-bot>=12.0 pip packages. The reason is a change in how arguments are passed to the callbacks. See the official transition guide here: https://github.com/python-telegram-bot/python-telegram-bot/wiki/Transition-guide-to-Version-12.0#context-based-callbacks
I fixed the code accordingly. I also tested each Telegram command individually and it worked successfully.
If you don't mind, you can merge the changes.
Regards