Collection of bug fixes - Change regex to basic#101
Open
lectrode wants to merge 3 commits into
Open
Conversation
* crash when `width` variable is not defined (resolves #2) * add support for + and @ symbols (resolves #3) FEATURE CHANGE: * extended regex incompatible with symbol support; basic used instead CODE NOTES: * new global variables for valid character sets for `tr -dc` instances Signed-off-by: Lectrode <electrodexsnet@gmail.com>
BUG FIXES: * echo to /dev/tty to ensure functions properly display text * main error messages output to STDERR Resolves #4 Signed-off-by: Lectrode <electrodexsnet@gmail.com>
BUG FIXES:
* Typo in apacman line 1769
* proot crash workaround (set PROOT_NO_SECCOMP=1)
* Skip test for broken package ("broken" package no longer exists)
* Fix proot -b parameter in multiple tests
* Fix number of packages to test for in ttf-font
Resolves #6
Signed-off-by: Lectrode <electrodexsnet@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the following:
Resolves #63
.*(example:apacman -S apacm.*)Resolves #79
+and@symbols in packagesResolves #80
echoto/dev/ttyto ensure it is visibleResolves #86
Additionally, this fixes some of the tests in
tests.bats(including aprootcrash workaround) and skips testing non-existant "broken" package.I also made sure to run the tests.bats file against my changes before submitting the pull request:
Let me know if there's anything you want to discuss