Skip to content

Wizard: Deprecate image mode flag (HMS-10721)#4463

Merged
kingsleyzissou merged 1 commit into
osbuild:mainfrom
regexowl:deprecate-image-mode-flag
May 26, 2026
Merged

Wizard: Deprecate image mode flag (HMS-10721)#4463
kingsleyzissou merged 1 commit into
osbuild:mainfrom
regexowl:deprecate-image-mode-flag

Conversation

@regexowl
Copy link
Copy Markdown
Collaborator

This deprecates 'image-builder.image-mode.enabled' flag to fully promote the functionality.

@regexowl regexowl changed the title Wizard: Deprecate image mode flag Wizard: Deprecate image mode flag (HMS-10721) May 26, 2026
@regexowl regexowl force-pushed the deprecate-image-mode-flag branch from 7d659eb to 80ff8ce Compare May 26, 2026 13:10
@codecov
Copy link
Copy Markdown

codecov Bot commented May 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.54%. Comparing base (b4838a9) to head (57a03c2).

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4463      +/-   ##
==========================================
+ Coverage   74.52%   74.54%   +0.02%     
==========================================
  Files         229      229              
  Lines        7481     7477       -4     
  Branches     2780     2778       -2     
==========================================
- Hits         5575     5574       -1     
+ Misses       1639     1636       -3     
  Partials      267      267              
Files with missing lines Coverage Δ
...ents/CreateImageWizard/steps/ImageOutput/index.tsx 89.65% <100.00%> (+2.55%) ⬆️
src/Utilities/useGetEnvironment.ts 42.85% <ø> (+3.72%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4838a9...57a03c2. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@regexowl regexowl marked this pull request as ready for review May 26, 2026 13:25
@regexowl regexowl requested a review from a team as a code owner May 26, 2026 13:25
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

mgold1234
mgold1234 previously approved these changes May 26, 2026
Copy link
Copy Markdown
Collaborator

@mgold1234 mgold1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

kingsleyzissou
kingsleyzissou previously approved these changes May 26, 2026
This deprecates 'image-builder.image-mode.enabled' flag to fully promote the functionality.
@regexowl regexowl dismissed stale reviews from kingsleyzissou and mgold1234 via 57a03c2 May 26, 2026 14:33
@regexowl regexowl force-pushed the deprecate-image-mode-flag branch from 80ff8ce to 57a03c2 Compare May 26, 2026 14:33
@regexowl
Copy link
Copy Markdown
Collaborator Author

/retest

@regexowl
Copy link
Copy Markdown
Collaborator Author

Resolved the conflicts

@kingsleyzissou kingsleyzissou added this pull request to the merge queue May 26, 2026
@kingsleyzissou
Copy link
Copy Markdown
Collaborator

Will wait for this to land before approving the next one 😅

Merged via the queue into osbuild:main with commit 90c577c May 26, 2026
37 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants