tests: Fix Compliance distro selector

[tkoscieln]

SSIA

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.66%. Comparing base (f591572) to head (37e6633).
⚠️ Report is 1 commits behind head on main.

@@           Coverage Diff           @@
##             main    #4445   +/-   ##
=======================================
  Coverage   74.66%   74.66%           
=======================================
  Files         229      229           
  Lines        7568     7568           
  Branches     2834     2831    -3     
=======================================
  Hits         5651     5651           
  Misses       1660     1660           
  Partials      257      257           

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a1f402...37e6633. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sourcery-ai]

Hey - I've left some high level feedback:

• The distroId derivation assumes only whitespace differences and simple lowercase transformations; consider centralizing this logic or aligning it with the actual DOM/id generation function to avoid subtle mismatches if ids change (e.g., special characters, punctuation).
• In ComplianceCIS.boot.ts you now hardcode label[for="rhel10-input"] while helpers.ts computes the id dynamically; consider reusing the helper logic or a shared utility to keep selection of distro inputs consistent across tests.
• Relying on label[for="..."] selectors ties the tests to specific id attributes; if possible, prefer more stable selectors (e.g., data attributes or accessible names) to reduce brittleness when markup changes.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The distroId derivation assumes only whitespace differences and simple lowercase transformations; consider centralizing this logic or aligning it with the actual DOM/id generation function to avoid subtle mismatches if ids change (e.g., special characters, punctuation).
- In `ComplianceCIS.boot.ts` you now hardcode `label[for="rhel10-input"]` while `helpers.ts` computes the id dynamically; consider reusing the helper logic or a shared utility to keep selection of distro inputs consistent across tests.
- Relying on `label[for="..."]` selectors ties the tests to specific id attributes; if possible, prefer more stable selectors (e.g., data attributes or accessible names) to reduce brittleness when markup changes.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[mgold1234]

/lgtm

[avitova]

It almost seems like the getByRole for distros stopped working? Should we use getByText?
Because the failure is for different reasons than what you are fixing, it seems.

[tkoscieln]

It almost seems like the getByRole for distros stopped working? Should we use getByText? Because the failure is for different reasons than what you are fixing, it seems.

That's a different issue patternfly/patternfly-react#12422 and it has to be fixed in Patternfly patternfly/patternfly-react#12424. Since we started using Modal, I have discovered a bug where the Modal sometimes sets aria-hidden to true for dropdowns, which is what PW uses for navigation.