Open
Conversation
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Replace API struct with Controller containing APIServer, Client, and NATSConnection. Update osapi.yaml config files. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Move heartbeat to internal/controller/ as a controller concern. Update all import paths project-wide. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Remove cmd/api.go parent, add cmd/controller.go - Rename apiServerCmd → controllerCmd, apiServerStartCmd → controllerStartCmd - Rename client api → client controller commands - Update all appConfig.API references to appConfig.Controller - Fix all test config literals (config.API → config.Controller) - Update setupAPIServer → setupController and related functions 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Update CLAUDE.md, configuration.md, architecture.md, system-architecture.md, development.md, health-checks.md, notifications.md, and intro.md. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
Thank you for contributing to this project! 😊🕹️ |
- Fix import paths in *.gen.go and cfg.yaml files - Fix SDK client gen/generate.go path - Fix justfile redocly join path - Change heartbeat component type from "api" to "controller" - Update client controller status filter - Update architecture docs to describe controller sub-components - Fix health status handler to recognize "controller" type 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Fix import ordering, indentation, and line wrapping applied by linter. Complete remaining API → Controller renames in docs and config types. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Add package-comments for controller and cmd packages. Remove gomock_reflect temp directory that was accidentally committed. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #287 +/- ##
=======================================
Coverage 99.84% 99.84%
=======================================
Files 227 227
Lines 9925 9925
=======================================
Hits 9910 9910
Misses 11 11
Partials 4 4
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rename the "API server" to "controller" to reflect its role as the control
plane process that owns the REST API, heartbeat, and notification watcher.
api.*→controller.*(YAML and env vars)osapi api server start→osapi controller startinternal/api/→internal/controller/api/,internal/notify/→internal/controller/notify/internal/controller/as a controller concernBreaking changes
api.*→controller.*OSAPI_API_*→OSAPI_CONTROLLER_*osapi api server start→osapi controller start🤖 Generated with Claude Code