feat: Added config option to disable server autoconnect.

[daneofmanythings]

This is an implementation of the feature request from issue #443. Let me know how it looks, thanks!

[osa1]

Hi @daneofmanythings. Thanks for the PR. This doesn't build currently, could you have a look?

We should also update crates/tiny/config.yml showing the usage of this field. It should be a commented-out configuration just like the other options in the file.

Regarding the option name (autoconn), what do other IRC clients use for this option? If possible we should use the same. Some alternatives: autoconnect, auto_conn, auto_connect.

[daneofmanythings]

Thanks for the quick response! I'm not sure why the pr got closed. I did not do that on purpose. I believe I have fixed the compiler errors, but I will verify. As for the name, I will change it to autoconnect, and will add a short description in config.yaml.

[daneofmanythings]

I am sorry, I didn't expect the CI it to rerun right away from the PR. I'll fix it.

[osa1]

I wasn't suggesting we should rename the option. I was asking what other clients use. I had a look:

• Weechat seems to be using "autoconnect" (https://docs.rohitfarmer.com/irc/weechat/#libera)
• irssi seems to be using "auto" (https://irssi.org/documentation/manual/automation/)
• glirc seems to be using "autoconnect" (https://github.com/glguy/irc-core/blob/501fbec552c74a7d8e9ae522027c24f5ef694363/src/Client/Configuration/ServerSettings.hs#L370-L371)
• Halloy doesn't seem to have an option for this.

Based on this I now suggest we should call it "autoconnect".

[daneofmanythings]

Thanks for the notes, I have adjusted the wording! I apologize for the failed build attempts, It builds and passes tests on my machine now. I am quite new to rust, and am making dumb mistakes.

[osa1]

Thanks @daneofmanythings. Just one more thing added..

If you're looking to contribute more would you like to pick up #461 after this one?

[osa1]

I've noticed that in other boolean options we specify the default, and then the commented-out option inverts the default value. E.g.

      # Sets /ignore for this server and all its tabs. Default is false.
      # ignore: true

For consistency we should do the same. So mention the default ("Default is true."), then make the option false in the commented-out code.

[daneofmanythings]

Good catch on that! I have made the adjustment.

I'd be happy to take a look at that feature request. Like i said before, I am very new to rust and I expect that to be reflected in the code I write, but I will give it a shot! Should I open a new PR for it when I have my first pass?

[osa1]

Should I open a new PR for it when I have my first pass?

Sure. I'm happy to advise/help as long as you're not vibe-coding.

[daneofmanythings]

AI does not touch my code. I prefer to write bugs by hand :)