Add doc regeneration rule to AGENTS.md#846
Conversation
WalkthroughAdded two documentation workflow commands: 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
6b35d23 to
48e4957
Compare
Deploying infrahub-sdk-python with
|
| Latest commit: |
56b6e2d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://641bb6d0.infrahub-sdk-python.pages.dev |
| Branch Preview URL: | https://pmi-20260220-update-agents-r.infrahub-sdk-python.pages.dev |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@AGENTS.md`:
- Line 57: The Never section still references legacy tasks; find the entries
that mention `uv run invoke generate-infrahubctl` and `uv run invoke
generate-sdk` (the lines that tell contributors how to regenerate docs) and
replace them with unified guidance to regenerate using `uv run invoke
docs-generate`, e.g., update the two bullets to read that
`docs/infrahubctl/*.mdx` and `docs/python-sdk/reference/config.mdx` should be
edited directly and regenerated with `uv run invoke docs-generate` instead of
the old individual commands.
6a7ebfa to
acfa9ec
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/AGENTS.md`:
- Line 69: Update the guidance that protects generated infrahubctl docs to use a
recursive glob: replace the current pattern `docs/infrahubctl/*.mdx` with
`docs/infrahubctl/**/*.mdx` and update the instructional text to "Do not edit
`docs/infrahubctl/**/*.mdx` files directly; regenerate with `uv run invoke
generate-infrahubctl`" so nested generated pages are also covered.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
AGENTS.mddocs/AGENTS.md
🚧 Files skipped from review as they are similar to previous changes (1)
- AGENTS.md
acfa9ec to
56b6e2d
Compare
There was a problem hiding this comment.
♻️ Duplicate comments (1)
docs/AGENTS.md (1)
69-69:⚠️ Potential issue | 🟡 MinorUse a recursive glob for generated infrahubctl docs.
docs/infrahubctl/*.mdxmisses nested generated pages; usedocs/infrahubctl/**/*.mdxinstead.Suggested fix
-- Edit `docs/infrahubctl/*.mdx` directly (regenerate with `uv run invoke docs-generate`) +- Edit `docs/infrahubctl/**/*.mdx` directly (regenerate with `uv run invoke docs-generate`)Based on learnings: "Applies to docs/infrahubctl/**/*.mdx : Do not edit
docs/infrahubctl/*.mdxfiles directly; regenerate withuv run invoke generate-infrahubctlinstead".🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/AGENTS.md` at line 69, Update the documentation text that currently references the glob "docs/infrahubctl/*.mdx" to use a recursive glob "docs/infrahubctl/**/*.mdx" so nested generated pages are included, and change the regeneration instruction from "uv run invoke docs-generate" to the correct command "uv run invoke generate-infrahubctl"; modify the sentence that warns not to edit generated files (the string mentioning docs/infrahubctl/*.mdx) to instead read "Do not edit docs/infrahubctl/**/*.mdx directly; regenerate with uv run invoke generate-infrahubctl" so both the glob and command are accurate.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@docs/AGENTS.md`:
- Line 69: Update the documentation text that currently references the glob
"docs/infrahubctl/*.mdx" to use a recursive glob "docs/infrahubctl/**/*.mdx" so
nested generated pages are included, and change the regeneration instruction
from "uv run invoke docs-generate" to the correct command "uv run invoke
generate-infrahubctl"; modify the sentence that warns not to edit generated
files (the string mentioning docs/infrahubctl/*.mdx) to instead read "Do not
edit docs/infrahubctl/**/*.mdx directly; regenerate with uv run invoke
generate-infrahubctl" so both the glob and command are accurate.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
AGENTS.mddocs/AGENTS.md
🚧 Files skipped from review as they are similar to previous changes (1)
- AGENTS.md
Just seen the Agents.MD rule update on
stablebranch https://github.com/opsmill/infrahub-sdk-python/pull/837/changesAdapted it to new documentation generation code which has been merged in the following PRs: #822 & #832 & #833
Documentation
Add reminder to
run invoke docs-generateafter changing CLI commands, SDK config or Python docstrings so generated docs stay in sync.Summary by CodeRabbit