Skip to content

Don't assume that aimChart refers to an OCI registry. #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
opskumu merged 2 commits into from
Feb 26, 2025
Merged

Don't assume that aimChart refers to an OCI registry. #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d910ce3
Don't assume that aimChart an OCI registry.
bluecamel Feb 24, 2025
0fa027d
Fix path for registry config.
bluecamel Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,4 +307,4 @@ helmRegistries:
```

#### Helm settings registry config file
Both of the previous methods will also create/update the registry config file (the same as the helm CLI). However, you can also put this file in the container and helm-wrapper will use that to authenticate. By default, this file is located at `/home/helm/.config/registry/config.json`. Again, the domain must match the chart registry URL in the upgrade or install request. Refer to helm documentation on how to configure this. You can also use one of the other authentication methods and then look at the file that is created in the container.
Both of the previous methods will also create/update the registry config file (the same as the helm CLI). However, you can also put this file in the container and helm-wrapper will use that to authenticate. By default, this file is located at `/home/helm/.config/helm/registry/config.json`. Again, the domain must match the chart registry URL in the upgrade or install request. Refer to helm documentation on how to configure this. You can also use one of the other authentication methods and then look at the file that is created in the container.
12 changes: 8 additions & 4 deletions registries.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,10 +111,14 @@ func initRegistry(c *repo.Entry) (error) {
}

func createOCIRegistryClientForChartPathOptions(aimChart *string, chartPathOptions *action.ChartPathOptions) (*registry.Client, error) {
registryConfig, err := chartPathOptionsToRegistryConfig(aimChart, chartPathOptions)
if err != nil {
return nil, fmt.Errorf("Failed to convert chart path options to registry config: %s", err)
if strings.HasPrefix(*aimChart, "oci://") {
registryConfig, err := chartPathOptionsToRegistryConfig(aimChart, chartPathOptions)
if err != nil {
return nil, fmt.Errorf("Failed to convert chart path options to registry config: %s", err)
}

return createOCIRegistryClient(registryConfig)
}

return createOCIRegistryClient(registryConfig)
return nil, nil
}