dhcp/kea: Add unit tests, big smoke test via snapshots, a few smaller tests to catch regressions early#9455
Closed
dhcp/kea: Add unit tests, big smoke test via snapshots, a few smaller tests to catch regressions early#9455
Conversation
…with the same config.xml
Member
Author
|
With the latest changes this is already outdated. A unit test approach is better, lets scrap this for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The snapshots use only real data I input to the GUI and is fully validated.
A config.xml is sent through the current model, and the resulting json is compared to the snapshot samples. If they do not match, a detailed error message is generated.
Other than that, some smaller tests are for firewall rules, enabled logic, and interface parsing.
With that in place, I can test for major regressions in here: #9450
And it is also handy for the future, if somebody changes something in KEA, the tests will trigger (most likely), catching most regressions early.
If new features are added, the tests need to be maintained and expanded.