Skip to content

Enhance save_large_file log level#280

Open
benoit74 wants to merge 1 commit intomainfrom
enhance_progress_report
Open

Enhance save_large_file log level#280
benoit74 wants to merge 1 commit intomainfrom
enhance_progress_report

Conversation

@benoit74
Copy link
Collaborator

On "decent" connections like we have when we run a scraper, "--progress=dot:giga" log level is sufficient to get a log at least once a second. More verbose progress is just filling logs with unnecessary details.

Sample logs for a 312M file:

--2026-02-24 15:56:10--  https://assets.openfreemap.com/natural_earth/ofm.tar.gz
Resolving assets.openfreemap.com (assets.openfreemap.com)... 2a06:98c1:3121::3, 2a06:98c1:3120::3, 188.114.97.3, ...
Connecting to assets.openfreemap.com (assets.openfreemap.com)|2a06:98c1:3121::3|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 327659595 (312M) [application/octet-stream]
Saving to: ‘tmp/assets/natural_earth.tar.gz’

     0K ........ ........ ........ ........ 10% 54.5M 5s
 32768K ........ ........ ........ ........ 20% 60.7M 4s
 65536K ........ ........ ........ ........ 30% 47.2M 4s
 98304K ........ ........ ........ ........ 40% 31.9M 4s
131072K ........ ........ ........ ........ 51% 58.2M 3s
163840K ........ ........ ........ ........ 61% 56.3M 2s
196608K ........ ........ ........ ........ 71% 52.8M 2s
229376K ........ ........ ........ ........ 81% 58.1M 1s
262144K ........ ........ ........ ........ 92% 43.9M 0s
294912K ........ ........ ........         100% 46.5M=6.3s

2026-02-24 15:56:17 (49.4 MB/s) - ‘tmp/assets/natural_earth.tar.gz’ saved [327659595/327659595]

I don't think we should make this setting configurable, it looks like unnecessary burden for scraper developer. Even if connection if finally a bit slower, it should still update once every 10s or once every minute at worst (or scraper will probably not achieve to download the big file anyway).

@rgaudin WDYT?

On "decent" connections like we have when we run a scraper,
"--progress=dot:giga" log level is sufficient to get a log at
least once a second. More verbose progress is just filling logs
with unnecessary details.
@benoit74 benoit74 self-assigned this Feb 24, 2026
@benoit74 benoit74 requested a review from rgaudin February 24, 2026 16:16
@codecov
Copy link

codecov bot commented Feb 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.63%. Comparing base (5dfc065) to head (4a45384).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #280   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files          41       41           
  Lines        2496     2496           
  Branches      347      347           
=======================================
  Hits         2487     2487           
  Misses          7        7           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants