Open
Conversation
On "decent" connections like we have when we run a scraper, "--progress=dot:giga" log level is sufficient to get a log at least once a second. More verbose progress is just filling logs with unnecessary details.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #280 +/- ##
=======================================
Coverage 99.63% 99.63%
=======================================
Files 41 41
Lines 2496 2496
Branches 347 347
=======================================
Hits 2487 2487
Misses 7 7
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On "decent" connections like we have when we run a scraper, "--progress=dot:giga" log level is sufficient to get a log at least once a second. More verbose progress is just filling logs with unnecessary details.
Sample logs for a 312M file:
I don't think we should make this setting configurable, it looks like unnecessary burden for scraper developer. Even if connection if finally a bit slower, it should still update once every 10s or once every minute at worst (or scraper will probably not achieve to download the big file anyway).
@rgaudin WDYT?