refactor: delete traces of legacy metadata#127
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes remaining support for legacy on-disk “metadata” files in the inference stack, standardizing model loading and runner selection around manifest.json.
Changes:
- Removed
metadata.yaml/metadata.jsonfallback loading and legacy upgrade logic (Manifest.from_legacy_metadata). - Updated unit tests and fixtures to write/read
manifest.jsoninstead of legacy metadata. - Simplified runner factory docs/code to focus on manifest-based runner selection.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/unit/inference/test_model.py | Updates tests/helpers to generate manifest.json and removes legacy metadata test cases. |
| tests/unit/inference/test_manifest.py | Removes tests for legacy metadata → manifest upgrade path. |
| tests/unit/inference/test_callbacks.py | Updates callback wiring tests to use manifest.json. |
| src/physicalai/inference/runners/factory.py | Updates runner factory documentation and renames legacy-oriented variables. |
| src/physicalai/inference/model.py | Removes legacy metadata fallback loading and legacy backend extraction. |
| src/physicalai/inference/manifest.py | Deletes Manifest.from_legacy_metadata implementation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
samet-akcay
previously approved these changes
May 21, 2026
maxxgx
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Validation
Breaking changes