add uber-trace-id for request header#110
add uber-trace-id for request header#110aslongyouloveme wants to merge 2 commits intoopentracing-contrib:masterfrom
Conversation
...ng-spring-web/src/main/java/io/opentracing/contrib/spring/web/webfilter/TracingOperator.java
Outdated
Show resolved
Hide resolved
|
@aslongyouloveme could you please help me understand this change and describe why it is needed? The request already contains span context. This span context was used as a parent to span created in the subscribe method. |
|
I used springcloud-gateway as the gateway, and downstream order-to-service is a micro service, gateway is a webflux application, and order-to-service is a servlet application. When I integrated jaeger, order-to-service could not get spancontext of gateway, because header (ude-trace-id) was not added in the forwarded request header. @ |
|
It sounds fine, thanks for the explanation. Could you write a test for the functionality you are adding? |
|
I would like to write a test case for it, I did not find any specimen test case for ‘TracingOperator.java’. |
|
I am more interested in integration test. There are some for webflux which should use this class. |
so microservice can get this for inherit span