chore(ci): Fix update-platform-branch to properly set platform.branch and update PR details #342
chore(ci): Fix update-platform-branch to properly set platform.branch and update PR details #342elizabethhealy wants to merge 7 commits intomainfrom
Conversation
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
X-Test Failure Report |
X-Test Failure Report |
|
/gemini review |
|
/gemini summary |
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
There was a problem hiding this comment.
Pull request overview
Updates the CI workflow that syncs platform.branch by ensuring PR bodies include protocol release notes and that existing PRs get updated instead of only creating new ones.
Changes:
- Add a step to fetch protocol release notes and write a
pr_body.txt. - Add a step to edit an existing PR’s title/body when one already exists.
- Move PR body generation earlier so both “edit PR” and “create PR” share it.
Comments suppressed due to low confidence (1)
.github/workflows/update-platform-branch.yaml:150
LATEST_TAGis sometimes a full tag likeprotocol/go/v0.3.1(per the workflow’s own testing comment / manual input), but this step assumes it’s only the version suffix and prependsprotocol/go/again. That results in an invalid tag (protocol/go/protocol/go/v0.3.1) and also produces an incorrect release URL in the PR body. Consider normalizing to a single canonical variable (e.g.,PROTOCOL_TAGalwaysprotocol/go/...) and derive the value consistently for both auto-discovery and manual input before using it here.
RELEASE_NOTES=$(gh release view protocol/go/$LATEST_TAG --repo opentdf/platform --json body --jq '.body')
cat <<EOF > pr_body.txt
This PR updates the platform.branch property in all pom.xml files to the new tag or branch: $LATEST_TAG.
See the release: https://github.com/opentdf/platform/releases/tag/protocol%2Fgo%2F$LATEST_TAG
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
X-Test Failure Report |
X-Test Failure Report |
X-Test Failure Report |
|
elizabethhealy
changed the title
elizabethhealy
changed the title
X-Test Results✅ go-main |
Updates the CI workflow that syncs platform.branch by ensuring PR bodies include protocol release notes and that existing PRs get updated instead of only creating new ones. Properly set the platform.branch.
Changes:
Add a step to fetch protocol release notes and write a pr_body.txt.
Add a step to edit an existing PR’s title/body when one already exists.
Move PR body generation earlier so both “edit PR” and “create PR” share it.
Fix how were setting the platform.branch
#308