Skip to content

[worker] Remove unused WithTx field and related configuration #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cgalibern merged 1 commit into from
Mar 17, 2026
Merged

[worker] Remove unused WithTx field and related configuration #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion cmd/conf.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ func setDefaultWorkerConfig(name string) {
viper.SetDefault(section+".metrics.enable", false)

viper.SetDefault(section+".runners", 1)
viper.SetDefault(section+".tx", true)
viper.SetDefault(section+".log.request.level", "none")
}

Expand Down
1 change: 0 additions & 1 deletion cmd/worker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@ func (t *workerT) run() error {
DB: t.db,
Redis: t.redis,
Queues: t.queues,
WithTx: viper.GetBool(t.section + ".tx"),
Ev: ev,
Runners: t.runners,
SubSystem: t.Section(),
Expand Down
2 changes: 0 additions & 2 deletions worker/worker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ type (
ODB *cdb.DB

Queues []string
WithTx bool
Ev EventPublisher

// Runners is the maximum number of jobs to run in parallel.
Expand Down Expand Up @@ -89,7 +88,6 @@ var (

func (w *Worker) Run() error {
slog.Info(fmt.Sprintf("starting %d runners for queues: %s", w.Runners, strings.Join(w.Queues, ", ")))
slog.Info(fmt.Sprintf("tx enabled: %v", w.WithTx))
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
jobC := make(chan []string, w.Runners)
Expand Down
Loading