Open
Conversation
… enforce Superpowers+workflow integration - Save Reviewer Agent report (.ai/reviews/review-feat-20260324.md): Needs Revision with 8 fail items - Add LL-001~005 to .ai/lessons-learned.md (header-after-WriteHeader, void-helper double-write, server->db cross-layer, unused mock server, Superpowers bypassing workflow) - Add AP-001~003 to .ai/anti-patterns.md with machine-detectable grep commands - Update CLAUDE.md rules 2 & 3: enforce superpowers:brainstorming + task-prompt-generator as mandatory parallel steps; enforce superpowers:verification-before-completion + code-review-validation before every commit
…w-feat-20260324 - F1: move LFS-Authenticate header before WriteHeader in dealWithAuthError and dealWithGithubAuthError - F2: addGithubMetaData returns error; handleGithubBatch returns early on error to prevent double write - F4/F5/F6: rewrite github_auth_test.go with patchGithubAPI monkey-patch helper; 13 tests cover all paths with mock server, no real API calls - F7: verifyGithubDownload fallback distinguishes 401 vs 403; propagates unauthorized prefix for expired tokens - S1: verifyGithubDelete English-only error with unauthorized: prefix for correct HTTP status classification
…rkflow-enforcer via @ in CLAUDE.md
CLA Signature PassZherphy, thanks for your pull request. All authors of the commits have signed the CLA. 👍 |
Linking Issue Notice@Zherphy , the pull request must be linked to at least one issue. |
|
开始门禁检查，等门禁检查通过后可以合入 |
|
|||||||||||||||||||
…ocal-ci-go skill
Security fixes:
- Add #nosec G706 to log.Printf in server.go (%q format, 4 locations)
- Add #nosec G304 to os.ReadFile in utils/util.go and auth/gitee.go
PowerShell CI script fixes (run_tests/run_security/run_gitleaks.ps1):
- Quote './...' and '-func=coverage.out' to prevent argument splitting
- Fix '${file}:' variable expansion and '/${file}:' path matching
- Set ErrorActionPreference=Continue before native commands writing stderr
Tests:
- auth/gitee_test.go: add TestVerifyUserDelete/Upload/Download,
TestResolveScriptPath, TestCreateTempOutputFile, TestParseOutputFile,
TestGetAccountManageToken, TestGetOpenEulerUserInfo, TestGetLFSMapping
- server/server_test.go: add TestApplySearchFilter
CI skill:
- Add .ai/skills/local-ci-go/ with full scripts (tests, security, gitleaks,
prerequisites, install tools, run_all, security-fix agents)
CLA Signature PassZherphy, thanks for your pull request. All authors of the commits have signed the CLA. 👍 |
|
开始门禁检查，等门禁检查通过后可以合入 |
|
|||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
描述
相关 Issue
变更类型