[サイト内検索] 検索対象が固定記事の場合、検索結果にフレームのアンカーを追加する/検索結果0件のときにメッセージを表示する#2387
Open
akagane99 wants to merge 2 commits intoopensource-workshop:masterfrom
Open
[サイト内検索] 検索対象が固定記事の場合、検索結果にフレームのアンカーを追加する/検索結果0件のときにメッセージを表示する#2387akagane99 wants to merge 2 commits intoopensource-workshop:masterfrom
akagane99 wants to merge 2 commits intoopensource-workshop:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
前述の対応です。
(補足)検索対象が固定記事の場合、検索結果にフレームのアンカーを追加する
検索結果表示には実質2パターンありました(⓵
show_page_frame_post②show_page③それ以外)※ ③は想定外パターンで入らない。
固定記事のみ②で、他は⓵でした。
resources/views/plugins/user/searchs/default/searchs_result.blade.php
固定記事の検索処理で
$searchs_result->frame_idをセットしていましたので、今回の対応を入れました。app/Plugins/User/Contents/ContentsPlugin.php
修正後画面
検索対象が固定記事の場合、検索結果にフレームのアンカーを追加
↓↓↓
検索結果0件メッセージ
レビュー完了希望日
急ぎません
関連Pull requests/Issues
概要に記載しました。
参考
なし
DB変更の有無
なし
チェックリスト