Skip to content

fix(machine): propagate MaxConcurrentReconciles to drain controller#1476

Open
loick111 wants to merge 1 commit intoopenshift:release-4.18from
loick111:fix/drain-controller-concurrent-reconciles
Open

fix(machine): propagate MaxConcurrentReconciles to drain controller#1476
loick111 wants to merge 1 commit intoopenshift:release-4.18from
loick111:fix/drain-controller-concurrent-reconciles

Conversation

@loick111
Copy link

The drain controller was always created with default options, ignoring the MaxConcurrentReconciles value passed via caller opts. This meant platforms like Azure that set concurrent reconciles to 10 would still have the drain controller running with a single worker, creating a bottleneck during large-scale drain operations.

Propagate MaxConcurrentReconciles from the incoming opts to the drain controller options so both controllers scale equally.

Case: #04399828

The drain controller was always created with default options, ignoring
the MaxConcurrentReconciles value passed via caller opts. This meant
platforms like Azure that set concurrent reconciles to 10 would still
have the drain controller running with a single worker, creating a
bottleneck during large-scale drain operations.

Propagate MaxConcurrentReconciles from the incoming opts to the drain
controller options so both controllers scale equally.

Case: #04399828
@coderabbitai
Copy link

coderabbitai bot commented Mar 13, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 95429fc2-161f-4e49-b773-a003daa33544

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can generate a title for your PR based on the changes with custom instructions.

Set the reviews.auto_title_instructions setting to generate a title for your PR based on the changes in the PR with custom instructions.

@openshift-ci openshift-ci bot requested review from RadekManak and nrb March 13, 2026 15:35
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 13, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign elmiko for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 13, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 13, 2026

Hi @loick111. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant