Skip to content

[release-4.12] OCPBUGS-78271: hermetic 4.12 #1470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fgallott wants to merge 2 commits into
base: release-4.12
Choose a base branch
from
Open

[release-4.12] OCPBUGS-78271: hermetic 4.12 #1470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c33403
hermetic 4.12
fgallott Mar 3, 2026
aa024c0
fix for tests
fgallott Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,9 @@ else
endif

PROJECT_DIR := $(shell dirname $(abspath $(lastword $(MAKEFILE_LIST))))
ENVTEST = go run ${PROJECT_DIR}/vendor/sigs.k8s.io/controller-runtime/tools/setup-envtest
# ENVTEST_K8S_VERSION refers to the version of kubebuilder assets to be downloaded by envtest binary.
ENVTEST_K8S_VERSION = 1.25
ENVTEST_K8S_VERSION = 1.28.0
ENVTEST_ASSETS_DIR ?= /tmp/controller-tools/envtest

.PHONY: vendor
vendor:
Expand Down Expand Up @@ -97,8 +97,19 @@ test: ## Run tests
@echo -e "\033[32mTesting...\033[0m"
$(DOCKER_CMD) hack/ci-test.sh

unit:
$(DOCKER_CMD) KUBEBUILDER_ASSETS="$(shell $(ENVTEST) use $(ENVTEST_K8S_VERSION) -p path --bin-dir $(PROJECT_DIR)/bin)" go test $(GOTEST_FLAGS) ./pkg/... ./cmd/...
.PHONY: setup-envtest
setup-envtest: ## Set up envtest (download kubebuilder assets)
@[ -f $(ENVTEST_ASSETS_DIR)/kube-apiserver ] || { \
set -e ;\
ARCH=$$(go env GOARCH) ;\
OS=$$(go env GOOS) ;\
echo "Downloading envtest binaries for k8s $(ENVTEST_K8S_VERSION) ($${OS}/$${ARCH})..." ;\
curl -fSL "https://github.com/kubernetes-sigs/controller-tools/releases/download/envtest-v$(ENVTEST_K8S_VERSION)/envtest-v$(ENVTEST_K8S_VERSION)-$${OS}-$${ARCH}.tar.gz" -o /tmp/envtest.tar.gz ;\
tar -xzf /tmp/envtest.tar.gz -C /tmp/ ;\
}

unit: setup-envtest
$(DOCKER_CMD) KUBEBUILDER_ASSETS="$(ENVTEST_ASSETS_DIR)" go test $(GOTEST_FLAGS) ./pkg/... ./cmd/...

.PHONY: image
image: ## Build docker image
Expand Down
89 changes: 89 additions & 0 deletions vendor/github.com/go-errors/errors/cover.out
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.