Skip to content

OCPBUGS-81482: [4.19] Add changes supporting kernel mr5470#582

Open
vitus133 wants to merge 9 commits intoopenshift:release-4.19from
vitus133:4.19-mr5470
Open

OCPBUGS-81482: [4.19] Add changes supporting kernel mr5470#582
vitus133 wants to merge 9 commits intoopenshift:release-4.19from
vitus133:4.19-mr5470

Conversation

@vitus133
Copy link
Copy Markdown
Contributor

@vitus133 vitus133 commented Mar 31, 2026

manual cherry-pick of changes supporting kernel mr 5470
/cc @nocturnalastro

vitus133 and others added 9 commits March 31, 2026 12:39
@vitus133
Reject phase offsets of inactive input pins
709ce5c 
The DPLL FFO feature introduced additional pin reports.
These additional reports are generated because the pin FFO changed,
but the phase offset is indicated as 0. Such reports can be
misinterpreted and acted upon in the clock state decision function.
Ignore DPLL pin replies of inactive pins and exclude them from the
phase offset decision chain. Only allow pin replays matched by clock
ID and parent device of type "PPS" in the connected state.

Signed-off-by: Vitaly Grinberg <vgrinber@redhat.com>
Made-with: Cursor
@vitus133
Ignore phase offsets from non-input pins
15fd347 
Signed-off-by: Vitaly Grinberg <vgrinber@redhat.com>
@vitus133
Create DPLLPins abstraction and use them as fall back for SMA/U.FL pins
eca626b 
Made-with: Cursor

Signed-off-by: Vitaly Grinberg <vgrinber@redhat.com>
@nocturnalastro @vitus133
Remove pointer to pin commands
51a932b 
Assisted-by: Cursor
@nocturnalastro @vitus133
Add ts2phc.pin_index 1 when sysfs SMA pins are missing
bba0b3e
@nocturnalastro @vitus133
Merge pull request openshift#167 from nocturnalastro/set_pin_index
0630b3a 
Set pin index
@vitus133
Improve DPLL pin commands printing
51072e4
@vitus133
add SDP22 channel assignment
3f5e2bf
@vitus133
fix unit tests for pin compatibility
246c78b 
Made-with: Cursor
@openshift-ci openshift-ci bot requested a review from nocturnalastro March 31, 2026 11:05
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 31, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 31, 2026

@vitus133: This pull request references Jira Issue OCPBUGS-81482, which is invalid:

  • expected Jira Issue OCPBUGS-81482 to depend on a bug targeting a version in 4.20.0, 4.20.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

manual cherry-pick of changes supporting kernel mr 5470
/cc @nocturnalastro

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 31, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vitus133

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2026
@vitus133
Copy link
Copy Markdown
Contributor Author

vitus133 commented Mar 31, 2026

/jira refresh

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 31, 2026

@vitus133: This pull request references Jira Issue OCPBUGS-81482, which is invalid:

  • expected dependent Jira Issue OCPBUGS-81481 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 31, 2026

@vitus133: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nocturnalastro nocturnalastro Awaiting requested review from nocturnalastro

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vitus133 @openshift-ci-robot @nocturnalastro