Skip to content

OCPBUGS-81481: [4.20] Add changes supporting kernel mr5470#581

Open
vitus133 wants to merge 9 commits intoopenshift:release-4.20from
vitus133:4.20-mr5470
Open

OCPBUGS-81481: [4.20] Add changes supporting kernel mr5470#581
vitus133 wants to merge 9 commits intoopenshift:release-4.20from
vitus133:4.20-mr5470

Conversation

@vitus133
Copy link
Copy Markdown
Contributor

@vitus133 vitus133 commented Mar 31, 2026

manual cherry-pick of changes supporting kernel mr 5470
/cc @nocturnalastro

vitus133 and others added 9 commits March 31, 2026 10:55
@vitus133
Reject phase offsets of inactive input pins
f5a75b1 
The DPLL FFO feature introduced additional pin reports.
These additional reports are generated because the pin FFO changed,
but the phase offset is indicated as 0. Such reports can be
misinterpreted and acted upon in the clock state decision function.
Ignore DPLL pin replies of inactive pins and exclude them from the
phase offset decision chain. Only allow pin replays matched by clock
ID and parent device of type "PPS" in the connected state.

Signed-off-by: Vitaly Grinberg <vgrinber@redhat.com>
@vitus133
Ignore phase offsets from non-input pins
cebbf71 
Signed-off-by: Vitaly Grinberg <vgrinber@redhat.com>
@vitus133
Create DPLLPins abstraction and use them as fall back for SMA/U.FL pins
f9d57d0 
Assisted-By: cursor

Signed-off-by: Vitaly Grinberg <vgrinber@redhat.com>
@nocturnalastro @vitus133
Remove pointer to pin commands
7ef49fe 
Assisted-by: Cursor
@nocturnalastro @vitus133
Add ts2phc.pin_index 1 when sysfs SMA pins are missing
57dbd76
@nocturnalastro @vitus133
Merge pull request openshift#167 from nocturnalastro/set_pin_index
6facf71 
Set pin index
@vitus133
Improve DPLL pin commands printing
7c5ac7a
@vitus133
add SDP22 channel assignment
3c1e52b
@vitus133
fix unit tests for pin compatibility
fb35b82
@openshift-ci openshift-ci bot requested a review from nocturnalastro March 31, 2026 09:04
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 31, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 31, 2026

@vitus133: This pull request references Jira Issue OCPBUGS-81481, which is invalid:

  • expected Jira Issue OCPBUGS-81481 to depend on a bug targeting a version in 4.21.0, 4.21.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

manual cherry-pick of changes supporting kernel mr 5470
/cc @nocturnalastro

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 31, 2026

@vitus133: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@nocturnalastro
Copy link
Copy Markdown
Contributor

nocturnalastro commented Mar 31, 2026

/label backport-risk-assessed
/lgtm

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 31, 2026
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 31, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nocturnalastro, vitus133

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [nocturnalastro,vitus133]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lack
Copy link
Copy Markdown
Member

lack commented Apr 1, 2026

/verified later @Bonnie-Block

@openshift-ci-robot openshift-ci-robot added verified-later verified Signifies that the PR passed pre-merge verification criteria labels Apr 1, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Apr 1, 2026

@lack: This PR has been marked to be verified later by @bonnie-block.

Details

In response to this:

/verified later @Bonnie-Block

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nocturnalastro nocturnalastro Awaiting requested review from nocturnalastro

Assignees

@mffiedler mffiedler

@rbbratta rbbratta

@gsr-shanks gsr-shanks

@weliang1 weliang1

@anuragthehatter anuragthehatter

@huiran0826 huiran0826

@asood-rh asood-rh

@jechen0648 jechen0648

@obochan-rh obochan-rh

@qiowang721 qiowang721

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria verified-later

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.