OCPBUGS-78986: UPSTREAM: 137926: KEP-961: demote maxUnavailable feature in statefulset to off by default

[atiratree]

StatefulSet update rollout regression is getting reverted upstream.

[openshift-ci-robot]

@atiratree: This pull request references Jira Issue OCPBUGS-78986, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

StatefulSet update rollout regression is getting reverted upstream.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@atiratree: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

• 78f7230|UPSTREAM: 137926: KEP-961: demote maxUnavailable feature in statefulset to off by default: the upstream PR kubernetes/kubernetes#137926 has not yet merged

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 362badd6-5747-4f7e-b481-9ecb5199eda2

📥 Commits

Reviewing files that changed from the base of the PR and between a925ce0 and 78f7230.

📒 Files selected for processing (2)

• pkg/features/kube_features.go
• test/compatibility_lifecycle/reference/versioned_feature_list.yaml

---

Walkthrough

Updated the default value of the MaxUnavailableStatefulSet feature gate from true to false at Kubernetes version 1.35, maintaining Beta preRelease status. Changes reflected in both the feature gate configuration and the versioned feature list reference.

Changes

Cohort / File(s)	Summary
MaxUnavailableStatefulSet Feature Gate Default Update pkg/features/kube_features.go, test/compatibility_lifecycle/reference/versioned_feature_list.yaml	Changed MaxUnavailableStatefulSet feature gate default value from true to false for Kubernetes version 1.35 (Beta). Synchronized updates across feature gate definition and versioned reference spec.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

📝 Coding Plan

• Generate coding plan for human review comments

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

CodeRabbit can use TruffleHog to scan for secrets in your code with verification capabilities.

Add a TruffleHog config file (e.g. trufflehog-config.yml, trufflehog.yml) to your project to customize detectors and scanning behavior. The tool runs only when a config file is present.

[jubittajohn]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atiratree, jubittajohn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS [jubittajohn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jubittajohn]

/retest

[openshift-ci]

@atiratree: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-runc	78f7230	link	false	/test e2e-aws-ovn-runc

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[jubittajohn]

/verified by ci

https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_kubernetes/2632/pull-ci-openshift-kubernetes-master-k8s-e2e-conformance-aws/2034999127095382016/artifacts/k8s-e2e-conformance-aws/test/artifacts/junit_01.xml

<testcase name="[It] [sig-apps] StatefulSet Basic StatefulSet functionality [StatefulSetBasic] should perform rolling updates with maxUnavailable [FeatureGate:MaxUnavailableStatefulSet] [Beta] [Feature:OffByDefault]" classname="Kubernetes e2e suite" status="skipped" time="0">
<skipped message="skipped"/>
</testcase>

and the same file shows that all the standard StatefulSet tests passes

[openshift-ci-robot]

@jubittajohn: This PR has been marked as verified by ci.

Details

In response to this:

/verified by ci

https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_kubernetes/2632/pull-ci-openshift-kubernetes-master-k8s-e2e-conformance-aws/2034999127095382016/artifacts/k8s-e2e-conformance-aws/test/artifacts/junit_01.xml

<testcase name="[It] [sig-apps] StatefulSet Basic StatefulSet functionality [StatefulSetBasic] should perform rolling updates with maxUnavailable [FeatureGate:MaxUnavailableStatefulSet] [Beta] [Feature:OffByDefault]" classname="Kubernetes e2e suite" status="skipped" time="0">
<skipped message="skipped"/>
</testcase>

and the same file shows that all the standard StatefulSet tests passes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.