CNTRLPLANE-2076: remove v2 import aliases left from SDK migration

[LiangquanLi930]

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes

Special notes for your reviewer:

Checklist:

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Summary by CodeRabbit

Refactor

• Updated internal AWS SDK package references throughout the codebase by removing import aliases and adopting direct package imports across infrastructure utilities, control-plane operations, and test components to improve code consistency and maintainability.

[openshift-ci-robot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@LiangquanLi930: This pull request references CNTRLPLANE-2076 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes

Special notes for your reviewer:

Checklist:

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 6fd1e548-7e27-40af-badb-d1cfcf5fea66

📥 Commits

Reviewing files that changed from the base of the PR and between 4ce92a2 and 696ea2e.

📒 Files selected for processing (13)

• cmd/fix/dr_oidc_iam.go
• cmd/infra/aws/destroy_test.go
• cmd/infra/aws/util/errors.go
• cmd/infra/aws/util/sts.go
• cmd/infra/aws/util/sts_test.go
• cmd/infra/aws/util/util.go
• cmd/infra/aws/util/util_test.go
• control-plane-operator/controllers/awsprivatelink/awsprivatelink_controller.go
• support/awsutil/sts.go
• test/e2e/util/fixture.go
• test/e2e/util/reqserving/setup.go
• test/e2e/util/sharedoidc.go
• test/e2e/util/util.go

✅ Files skipped from review due to trivial changes (8)

• test/e2e/util/sharedoidc.go
• cmd/infra/aws/destroy_test.go
• cmd/infra/aws/util/errors.go
• cmd/infra/aws/util/util_test.go
• support/awsutil/sts.go
• test/e2e/util/util.go
• test/e2e/util/reqserving/setup.go
• cmd/infra/aws/util/sts_test.go

🚧 Files skipped from review as they are similar to previous changes (2)

• test/e2e/util/fixture.go
• control-plane-operator/controllers/awsprivatelink/awsprivatelink_controller.go

---

📝 Walkthrough

Walkthrough

The pull request removes aliased imports of AWS SDK v2 packages throughout the codebase and replaces them with direct package imports. Aliased imports such as awsv2, configv2, route53v2, and stsv2 are replaced with unaliased imports like aws, config, route53, and sts. This change is propagated across function signatures (particularly in exported functions like NewSTSSession, ParseSTSCredentialsFile, and GetSession), internal helper functions, test code, and all call sites. Type references are updated mechanically from aliased forms (e.g., *awsv2.Config) to unaliased forms (e.g., *aws.Config). Control flow, error handling, and business logic remain unchanged.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci-robot]

@LiangquanLi930: This pull request references CNTRLPLANE-2076 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes

Special notes for your reviewer:

Checklist:

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Summary by CodeRabbit

Release Notes

• Refactor

• Standardized AWS SDK v2 dependency usage across the codebase to improve code consistency and maintainability. Internal implementations were updated to use direct package imports, with no impact on user-facing functionality or behavior.

• Tests

• Updated test suites to align with the standardized AWS SDK v2 usage patterns.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@cmd/infra/aws/util/util.go`:
- Around line 115-116: The NewSession function currently discards the error from
config.LoadDefaultConfig; change NewSession to return (*aws.Config, error),
capture and return the error from config.LoadDefaultConfig (do not ignore it),
and update the GetSession wrapper and all 19 call sites and tests to propagate
or handle the returned error accordingly so callers no longer receive a
seemingly valid config when loading fails; reference the NewSession function,
GetSession wrapper, and any call sites invoking NewSession to locate updates.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: e1e5336a-1a64-417e-8a22-cce05553b2a4

📥 Commits

Reviewing files that changed from the base of the PR and between 1375a78 and b22fa76.

📒 Files selected for processing (13)

• cmd/fix/dr_oidc_iam.go
• cmd/infra/aws/destroy_test.go
• cmd/infra/aws/util/errors.go
• cmd/infra/aws/util/sts.go
• cmd/infra/aws/util/sts_test.go
• cmd/infra/aws/util/util.go
• cmd/infra/aws/util/util_test.go
• control-plane-operator/controllers/awsprivatelink/awsprivatelink_controller.go
• support/awsutil/sts.go
• test/e2e/util/fixture.go
• test/e2e/util/reqserving/setup.go
• test/e2e/util/sharedoidc.go
• test/e2e/util/util.go

[jparrill]

/approve

[LiangquanLi930]

/pipeline required

[openshift-ci-robot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aks-4-21
/test e2e-aws-4-21
/test e2e-aks
/test e2e-aws
/test e2e-aws-upgrade-hypershift-operator
/test e2e-kubevirt-aws-ovn-reduced
/test e2e-v2-aws

[LiangquanLi930]

/test e2e-azure-self-managed

[cwbotbot]

Test Results

e2e-aws

• Status: ✅ PASS
• Started: 2026-03-26T04:56:14Z
• View Job
• View Job History

e2e-aks

• Status: ✅ PASS
• Started: 2026-03-26T04:56:10Z
• View Job
• View Job History

[sdminonne]

A good follow-up fix would be changing NewSession to return (*aws.Config, error)
Stopping swallowing error and make the rabbit happy :)

[openshift-ci-robot]

Tests from second stage were triggered manually. Pipeline can be controlled only manually, until HEAD changes. Use command to trigger second stage.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jparrill, LiangquanLi930, sdminonne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [jparrill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sdminonne]

/lgtm

[LiangquanLi930]

/retest

[LiangquanLi930]

/verified by e2e

[openshift-ci-robot]

@LiangquanLi930: This PR has been marked as verified by e2e.

Details

In response to this:

/verified by e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[sdminonne]

/lgtm

[LiangquanLi930]

/retest

[LiangquanLi930]

/test e2e-aks

[openshift-ci-robot]

@LiangquanLi930: This pull request references CNTRLPLANE-2076 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes

Special notes for your reviewer:

Checklist:

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Summary by CodeRabbit

• Refactor

• Standardized AWS SDK v2 usage across the codebase (imports and types), improving consistency and maintainability with no user-facing behavior changes.

• Tests

• Updated existing tests to match the SDK changes and added comprehensive Route53 unit tests to strengthen DNS-related coverage and reliability.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[YuLi517]

/lgtm

[openshift-ci-robot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aks-4-21
/test e2e-aws-4-21
/test e2e-aks
/test e2e-aws
/test e2e-aws-upgrade-hypershift-operator
/test e2e-kubevirt-aws-ovn-reduced
/test e2e-v2-aws

[LiangquanLi930]

/verified by e2e

[openshift-ci-robot]

@LiangquanLi930: This PR has been marked as verified by e2e.

Details

In response to this:

/verified by e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@LiangquanLi930: This pull request references CNTRLPLANE-2076 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes

Special notes for your reviewer:

Checklist:

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Summary by CodeRabbit

Refactor

• Updated internal AWS SDK package references throughout the codebase by removing import aliases and adopting direct package imports across infrastructure utilities, control-plane operations, and test components to improve code consistency and maintainability.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@LiangquanLi930: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.