Skip to content

feat: add API types for ExternalSecretsConfig component overrides (EP-1898)#130

Open
swghosh wants to merge 1 commit intoopenshift:ai-staging-release-1.0from
swghosh:feature/api-types-ep1898
Open

feat: add API types for ExternalSecretsConfig component overrides (EP-1898)#130
swghosh wants to merge 1 commit intoopenshift:ai-staging-release-1.0from
swghosh:feature/api-types-ep1898

Conversation

@swghosh
Copy link
Copy Markdown
Member

@swghosh swghosh commented Apr 6, 2026

Summary

  • Extends ExternalSecretsConfig API with annotations field for global custom annotations on all operand Deployments and Pod templates
  • Adds componentConfigs field for per-component configuration overrides (Controller, Webhook, CertController, BitwardenSDKServer)
  • Introduces DeploymentConfig type with revisionHistoryLimit and overrideEnv for custom environment variables per component
  • Includes CEL validation rules for reserved annotation prefixes and reserved environment variable name prefixes
  • Adds comprehensive integration test suite with 30+ new test cases covering create, update, and validation scenarios

Enhancement Proposal

openshift/enhancements#1898

Changes

File Description
api/v1alpha1/meta.go Added KVPair and Annotation types
api/v1alpha1/external_secrets_config_types.go Added ComponentConfig, DeploymentConfig types; extended ControllerConfig with annotations and componentConfigs fields; extended ComponentName enum with Webhook and CertController
api/v1alpha1/zz_generated.deepcopy.go Auto-generated deepcopy functions for new types
config/crd/bases/operator.openshift.io_externalsecretsconfigs.yaml Regenerated CRD manifest with new fields
api/v1alpha1/tests/.../externalsecretsconfig.testsuite.yaml 30+ new integration tests

Test plan

  • All new fields have valid-value creation tests
  • All validation rules (enums, min/max, reserved prefixes, uniqueness) have error-case tests
  • Update scenarios tested for annotations, componentConfigs, overrideEnv, and revisionHistoryLimit
  • make generate and make manifests pass successfully
  • go vet ./api/... passes with no issues

🤖 Generated with Claude Code

…-1898)

Extend the ExternalSecretsConfig API with:
- annotations: global custom annotations for all operand Deployments and Pod templates
- componentConfigs: per-component configuration overrides (Controller, Webhook,
  CertController, BitwardenSDKServer)
- deploymentConfig: deployment-level overrides including revisionHistoryLimit
- overrideEnv: custom environment variables per component with reserved prefix
  validation

Also extends ComponentName enum with Webhook and CertController values, adds
KVPair and Annotation types for structured annotation configuration, and includes
comprehensive integration test coverage for all new fields and validation rules.

Ref: openshift/enhancements#1898

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 6, 2026

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: da4d7ae2-c53e-4a11-9e08-fd9b0f7d4e79

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot requested review from TrilokGeer and mytreya-rh April 6, 2026 08:27
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 6, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: swghosh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant