feat: add API types for ExternalSecretsConfig component overrides (EP-1898)#130
feat: add API types for ExternalSecretsConfig component overrides (EP-1898)#130swghosh wants to merge 1 commit intoopenshift:ai-staging-release-1.0from
Conversation
…-1898) Extend the ExternalSecretsConfig API with: - annotations: global custom annotations for all operand Deployments and Pod templates - componentConfigs: per-component configuration overrides (Controller, Webhook, CertController, BitwardenSDKServer) - deploymentConfig: deployment-level overrides including revisionHistoryLimit - overrideEnv: custom environment variables per component with reserved prefix validation Also extends ComponentName enum with Webhook and CertController values, adds KVPair and Annotation types for structured annotation configuration, and includes comprehensive integration test coverage for all new fields and validation rules. Ref: openshift/enhancements#1898 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: swghosh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
ExternalSecretsConfigAPI withannotationsfield for global custom annotations on all operand Deployments and Pod templatescomponentConfigsfield for per-component configuration overrides (Controller, Webhook, CertController, BitwardenSDKServer)DeploymentConfigtype withrevisionHistoryLimitandoverrideEnvfor custom environment variables per componentEnhancement Proposal
openshift/enhancements#1898
Changes
api/v1alpha1/meta.goKVPairandAnnotationtypesapi/v1alpha1/external_secrets_config_types.goComponentConfig,DeploymentConfigtypes; extendedControllerConfigwithannotationsandcomponentConfigsfields; extendedComponentNameenum withWebhookandCertControllerapi/v1alpha1/zz_generated.deepcopy.goconfig/crd/bases/operator.openshift.io_externalsecretsconfigs.yamlapi/v1alpha1/tests/.../externalsecretsconfig.testsuite.yamlTest plan
make generateandmake manifestspass successfullygo vet ./api/...passes with no issues🤖 Generated with Claude Code