Skip to content

[release-4.19] OCPBUGS-76950: “Import from Git” should not force HTTPS/443 for Git providers (GitHub/GitLab/Bitbucket)#16028

Merged
openshift-merge-bot[bot] merged 4 commits intoopenshift:release-4.19from
openshift-cherrypick-robot:cherry-pick-15978-to-release-4.19
Mar 3, 2026
Merged

[release-4.19] OCPBUGS-76950: “Import from Git” should not force HTTPS/443 for Git providers (GitHub/GitLab/Bitbucket)#16028
openshift-merge-bot[bot] merged 4 commits intoopenshift:release-4.19from
openshift-cherrypick-robot:cherry-pick-15978-to-release-4.19

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

This is an automated cherry-pick of #15978

/assign krishagarwal278

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 16, 2026

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-74937 has been cloned as Jira Issue OCPBUGS-76950. Will retitle bug to link to clone.
/retitle [release-4.19] OCPBUGS-76950: “Import from Git” should not force HTTPS/443 for Git providers (GitHub/GitLab/Bitbucket)

Details

In response to this:

This is an automated cherry-pick of #15978

/assign krishagarwal278

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot changed the title [release-4.19] OCPBUGS-74937: “Import from Git” should not force HTTPS/443 for Git providers (GitHub/GitLab/Bitbucket) [release-4.19] OCPBUGS-76950: “Import from Git” should not force HTTPS/443 for Git providers (GitHub/GitLab/Bitbucket) Feb 16, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 16, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-76950, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-74937 to target a version in 4.20.0, 4.20.z, but it targets "4.22.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #15978

/assign krishagarwal278

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Feb 16, 2026
@openshift-ci openshift-ci Bot added component/dev-console Related to dev-console component/git-service Related to git-service labels Feb 16, 2026
@krishagarwal278
Copy link
Copy Markdown
Contributor

/jira refresh

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@krishagarwal278: This pull request references Jira Issue OCPBUGS-76950, which is invalid:

  • expected the bug to target only the "4.19.z" version, but multiple target versions were set
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-74937 to target a version in 4.20.0, 4.20.z, but it targets "4.22.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@krishagarwal278
Copy link
Copy Markdown
Contributor

/jira refresh

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@krishagarwal278: This pull request references Jira Issue OCPBUGS-76950, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@krishagarwal278
Copy link
Copy Markdown
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 16, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@krishagarwal278: This pull request references Jira Issue OCPBUGS-76950, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.z) matches configured target version for branch (4.19.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-74937 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-74937 targets the "4.20.0" version, which is one of the valid target versions: 4.20.0, 4.20.z
  • bug has dependents

Requesting review from QA contact:
/cc @yapei

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested a review from yapei February 16, 2026 15:29
@krishagarwal278
Copy link
Copy Markdown
Contributor

/retest

4 similar comments
@krishagarwal278
Copy link
Copy Markdown
Contributor

/retest

@krishagarwal278
Copy link
Copy Markdown
Contributor

/retest

@krishagarwal278
Copy link
Copy Markdown
Contributor

/retest

@krishagarwal278
Copy link
Copy Markdown
Contributor

/retest

@krishagarwal278
Copy link
Copy Markdown
Contributor

/retest

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2026
@krishagarwal278
Copy link
Copy Markdown
Contributor

/test okd-scos-images

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Feb 17, 2026

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-images 339eab8 link true /test okd-scos-images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@yanpzhan
Copy link
Copy Markdown
Contributor

yanpzhan commented Mar 3, 2026

Checked on cluster launched against the pr.
Login console, open f12 developer tool, on 'Import from GIt' page, test with urls 'https://gh.local:8443/org/repo',
'http://gh.local:8080/org/repo', 'http://gitlab.local:8080/grp/repo', 'http://bb.local:7990/scm/prj/repo', 'http://gitea.local:3000/user/repo' separately.
Filtered 'local' in 'Network' tab, see the api request is using correct https/http schema and port.
/verified by yanpzhan

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 3, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@yanpzhan: This PR has been marked as verified by yanpzhan.

Details

In response to this:

Checked on cluster launched against the pr.
Login console, open f12 developer tool, on 'Import from GIt' page, test with urls 'https://gh.local:8443/org/repo',
'http://gh.local:8080/org/repo', 'http://gitlab.local:8080/grp/repo', 'http://bb.local:7990/scm/prj/repo', 'http://gitea.local:3000/user/repo' separately.
Filtered 'local' in 'Network' tab, see the api request is using correct https/http schema and port.
/verified by yanpzhan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@logonoff
Copy link
Copy Markdown
Member

logonoff commented Mar 3, 2026

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 3, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@logonoff
Copy link
Copy Markdown
Member

logonoff commented Mar 3, 2026

/label backport-risk-assessed

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 3, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit 27396b7 into openshift:release-4.19 Mar 3, 2026
8 checks passed
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: Jira Issue Verification Checks: Jira Issue OCPBUGS-76950
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-76950 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

This is an automated cherry-pick of #15978

/assign krishagarwal278

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot
Copy link
Copy Markdown
Contributor

Fix included in accepted release 4.19.0-0.nightly-2026-03-05-131422

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. component/dev-console Related to dev-console component/git-service Related to git-service jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants