Skip to content

DNM Debug #1472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jmencak wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

DNM Debug #1472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3de1d3
DNM Debug
jmencak Feb 16, 2026
5d9beec
Fail intentionally
jmencak Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Node Tuning Operator
# Node Tuning Operator

The Node Tuning Operator (NTO) manages cluster node-level tuning for
[OpenShift](https://openshift.io/).
Expand Down
3 changes: 3 additions & 0 deletions test/extended/nto.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ var _ = g.Describe("[sig-tuning-node] PSAP should", g.Label("conformance"), func
})

g.It("[Jira:NTO]OCP-37415-Allow setting isolated_cores without touching the default_irq_affinity[OTP][Disruptive][Suite:openshift/conformance/serial]", g.Label("Serial"), func() {
g.By("fail intentionally for debugging in the CI to see if the tests are actually running")
o.Expect(err).To(o.HaveOccurred())

Comment on lines +39 to +41
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Intentional test failure — must not be merged.

This debugging code will always fail: err is nil at this point because it's zero-initialized on line 24, and BeforeEach shadows it with a local variable (:= on line 31). The o.Expect(err).To(o.HaveOccurred()) assertion expects a non-nil error, so the test fails as intended.

Given the PR is marked as DNM/Draft with commit message "Fail intentionally", this appears to serve its purpose for CI debugging. Ensure this is removed before any real merge.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@test/extended/nto.go` around lines 39 - 41, Remove the intentional failing
assertion and fix the shadowed error variable: eliminate the g.By("fail
intentionally...") and the o.Expect(err).To(o.HaveOccurred()) assertion, and
ensure the test uses the package-level or outer-scoped err (do not redeclare err
with := inside BeforeEach); if you need to assert an actual error, assign to the
existing err variable (use =) and assert its value appropriately in the test
instead of forcing a failure.

// test requires NTO to be installed
if !isNTO {
g.Skip("NTO is not installed - skipping test ...")
Expand Down