OCPBUGS-78230: [release-4.13] hermetic 4.13 by fgallott · Pull Request #594 · openshift/cluster-api-provider-aws

fgallott · 2026-02-24T10:57:59Z

same as #593

coderabbitai · 2026-02-24T10:58:12Z

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)

do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4d096bed-6d75-4ff2-ae03-52c54c7a514e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

fgallott · 2026-02-24T13:51:45Z

/test unit

damdo

/approve
/lgtm

openshift-ci · 2026-02-26T11:47:56Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [damdo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Two issues prevent upstream unit tests from passing in OpenShift CI: 1. CRD path resolution fails with vendoring. The upstream repo does not vendor, so `go test` uses module mode and downloads full module sources (including non-Go assets like CRD YAMLs) to $GOPATH/pkg/mod. The OpenShift fork vendors dependencies, and Go 1.14+ defaults to -mod=vendor when a vendor/ directory is present. Vendor directories only contain Go source files, so the cluster-api CRD YAMLs at $GOPATH/pkg/mod/sigs.k8s.io/cluster-api@.../config/crd/bases are never downloaded, causing test helpers to panic. Fix: explicitly set GOFLAGS=-mod=mod in unit-tests.sh to force module mode, matching upstream behaviour. 2. TestGetManagerNamespace fails due to mounted service account. GetManagerNamespace() reads /var/run/secrets/.../namespace before falling back to the POD_NAMESPACE env var. Upstream Prow runs tests on an EKS cluster where service account tokens are not automounted, so the file does not exist and the env var path is exercised. OpenShift CI (ci-operator) creates test pods with service accounts mounted, so the file exists and returns the CI namespace (ci-op-*) regardless of the env var the test sets. Fix: change inClusterNamespacePath from const to var so the test can override it, ensuring the env var fallback path is exercised in any CI environment. Additionally aligns unit-tests.sh with upstream scripts/ci-test.sh: source hack/ensure-go.sh and use make test-verbose. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

fgallott · 2026-03-11T11:39:24Z

/jira cherrypick OCPBUGS-78229

openshift-ci-robot · 2026-03-11T11:39:35Z

@fgallott: Jira Issue OCPBUGS-78229 has been cloned as Jira Issue OCPBUGS-78230. Will retitle bug to link to clone.
/retitle OCPBUGS-78230: [release-4.13] hermetic 4.13

Details

In response to this:

/jira cherrypick OCPBUGS-78229

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-03-11T11:39:45Z

@fgallott: This pull request references Jira Issue OCPBUGS-78230, which is invalid:

expected dependent Jira Issue OCPBUGS-78229 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

same as #593

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED

racheljpg · 2026-03-18T16:01:08Z

/label backport-risk-assessed
/lgtm

sunzhaohua2 · 2026-03-20T05:29:11Z

/retest

fgallott · 2026-03-24T19:55:49Z

/retest-required

fgallott · 2026-03-30T10:30:54Z

@damdo same here, the e2e-aws-serial failure is not related to my changes

fgallott · 2026-03-30T11:15:58Z

/retest

damdo · 2026-04-01T09:02:54Z

/override ci/prow/e2e-aws-serial

Permafailing for different reasons, see: https://redhat-internal.slack.com/archives/CBQHQFU0N/p1775033879132629?thread_ts=1767937484.954809&cid=CBQHQFU0N

damdo · 2026-04-01T09:03:07Z

/verified by images job passing

openshift-ci-robot · 2026-04-01T09:03:19Z

@damdo: This PR has been marked as verified by images job passing.

Details

In response to this:

/verified by images job passing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-04-01T09:04:31Z

@damdo: Overrode contexts on behalf of damdo: ci/prow/e2e-aws-serial

Details

In response to this:

/override ci/prow/e2e-aws-serial

Permafailing for different reasons, see: https://redhat-internal.slack.com/archives/CBQHQFU0N/p1775033879132629?thread_ts=1767937484.954809&cid=CBQHQFU0N

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci · 2026-04-01T09:04:33Z

@fgallott: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

fgallott · 2026-04-02T06:32:05Z

/jira refresh

openshift-ci-robot · 2026-04-02T06:32:13Z

@fgallott: This pull request references Jira Issue OCPBUGS-78230, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.13.z) matches configured target version for branch (4.13.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-78229 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-78229 targets the "4.14.z" version, which is one of the valid target versions: 4.14.0, 4.14.z
bug has dependents

Requesting review from QA contact:
/cc @sunzhaohua2

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-04-02T06:35:33Z

@fgallott: Jira Issue Verification Checks: Jira Issue OCPBUGS-78230
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-78230 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

same as #593

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

UPSTREAM: <carry>: hermetic 4.13

2a06ee5

fgallott mentioned this pull request Feb 24, 2026

OCPBUGS-78231: [release-4.12] hermetic 4.12 #595

Merged

openshift-ci Bot requested review from RadekManak and elmiko February 24, 2026 10:58

fgallott changed the title ~~UPSTREAM: <carry>: hermetic 4.13~~ [release-4.13] hermetic 4.13 Feb 25, 2026

damdo reviewed Feb 26, 2026

View reviewed changes

openshift-ci Bot assigned damdo Feb 26, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2026

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2026

openshift-ci Bot changed the title ~~[release-4.13] hermetic 4.13~~ OCPBUGS-78230: [release-4.13] hermetic 4.13 Mar 11, 2026

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 11, 2026

UPSTREAM: <carry>: fix unit tests

14dfb4b

rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED

fgallott force-pushed the hermetic-4.13 branch from cc55485 to 14dfb4b Compare March 16, 2026 15:14

openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 18, 2026

openshift-ci Bot assigned huali9, miyadav, sunzhaohua2 and racheljpg Mar 18, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Apr 1, 2026

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 2, 2026

openshift-ci Bot requested a review from sunzhaohua2 April 2, 2026 06:32

openshift-merge-bot Bot merged commit 85a6abb into openshift:release-4.13 Apr 2, 2026
6 checks passed

fgallott deleted the hermetic-4.13 branch April 2, 2026 07:28

fgallott mentioned this pull request Apr 2, 2026

hermetic 4.13 openshift-eng/ocp-build-data#9767

Merged

Conversation

fgallott commented Feb 24, 2026

Uh oh!

coderabbitai Bot commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

fgallott commented Feb 24, 2026

Uh oh!

damdo left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Feb 26, 2026

Uh oh!

fgallott commented Mar 11, 2026

Uh oh!

openshift-ci-robot commented Mar 11, 2026

Uh oh!

openshift-ci-robot commented Mar 11, 2026

Uh oh!

racheljpg commented Mar 18, 2026

Uh oh!

sunzhaohua2 commented Mar 20, 2026

Uh oh!

fgallott commented Mar 24, 2026

Uh oh!

fgallott commented Mar 30, 2026

Uh oh!

fgallott commented Mar 30, 2026

Uh oh!

damdo commented Apr 1, 2026

Uh oh!

damdo commented Apr 1, 2026

Uh oh!

openshift-ci-robot commented Apr 1, 2026

Uh oh!

openshift-ci Bot commented Apr 1, 2026

Uh oh!

openshift-ci Bot commented Apr 1, 2026

Uh oh!

fgallott commented Apr 2, 2026

Uh oh!

openshift-ci-robot commented Apr 2, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented Apr 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

coderabbitai Bot commented Feb 24, 2026 •

edited

Loading