CNTRLPLANE-2254: blocked-edges: Extend HyperShiftRedundantRouter risk…#8937
CNTRLPLANE-2254: blocked-edges: Extend HyperShiftRedundantRouter risk…#8937fao89 wants to merge 1 commit intoopenshift:masterfrom
Conversation
… to 4.19.25 Signed-off-by: Fabricio Aguiar <fabricio.aguiar@gmail.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
openshift-ci-robot
added
the
jira/valid-reference
|
@fao89: This pull request references CNTRLPLANE-2254 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fao89 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@fao89: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| @@ -0,0 +1,12 @@ | |||
| to: 4.19.25 | |||
| from: ^4[.]18[.]([0-9]|1[0-7])[+].*$ | |||
There was a problem hiding this comment.
The from regex seems to be different from the other HyperShiftRedundantRouter risk files. Was there a specific reason?
| @@ -0,0 +1,12 @@ | |||
| to: 4.19.25 | |||
There was a problem hiding this comment.
Comment not relevant to the selected line
In the PR description you reference:
OCPBUGS-70147 is currently New.
However, that's the 4.20.z bug. I believe we should be looking at the 4.19.z bug (OCPBUGS-69866).
There was a problem hiding this comment.
A rather nitpicky, redundant comment on my behalf, as 4.20 needs to be verified before 4.19 can progress. Noting just in case.
|
Sorry to jump in but 4.19.25 errata shipped today so this needed to get unblocked. Superseded by #8943 |
|
/close |
|
@sdodson: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
4 participants
This extends the existing HyperShift router risk from 4.19.24 to also cover 4.19.25, maintaining the same risk conditions for hosted clusters on bare metal or KubeVirt with route publishing strategy conflicts.
OCPBUGS-70147 is currently
New.ref: openshift/hypershift#7605