Skip to content

Migrate from deprecated AWS Account.Status to Account.State field#958

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
BATMAN-JD:SREP-1856-v2
Mar 24, 2026
Merged

Migrate from deprecated AWS Account.Status to Account.State field#958
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
BATMAN-JD:SREP-1856-v2

Conversation

@BATMAN-JD
Copy link
Copy Markdown
Contributor

AWS is deprecating the Account.Status field and will remove it on September 9, 2026. This change migrates the operator to use the new Account.State field to ensure continued compatibility.

Changes:

Upgraded AWS Organizations SDK from v1.34.0 to v1.50.5
Migrated totalaccountwatcher.go to use account.State instead of account.Status
Updated enum references: AccountStatusActive → AccountStateActive, AccountStatusSuspended → AccountStateSuspended
Updated 31 test fixtures in totalaccountwatcher_test.go
Regenerated CRDs, mocks, and OpenAPI schema
The new State field provides the same functionality with additional states (PENDING_ACTIVATION, CLOSED) for better account lifecycle management.

Ref: SREP-1856

What is being added?
Is this a fix for a bug? What's the bug? Is this a new feature? Please describe it. Is this just a small typo fix? That's fine too!

Checklist before requesting review
I have tested this locally
I have included unit tests
I have updated any corresponding documentation
Steps To Manually Test
Please provide us steps to reproduce the scenarios needed to test this. If an integration test is provided, let us know how to run it. If not, enumerate the steps to validate this does what it's supposed to.

Start the operator
Run the thing
Observe X in the spec for the thing
Clean up the thing
Ref SREP-1856

AWS is deprecating the Account.Status field and will remove it on
September 9, 2026. This change migrates the operator to use the new
Account.State field to ensure continued compatibility.

Changes:
- Upgraded AWS Organizations SDK from v1.34.0 to v1.50.5
- Migrated totalaccountwatcher.go to use account.State instead of account.Status
- Updated enum references: AccountStatusActive → AccountStateActive,
  AccountStatusSuspended → AccountStateSuspended
- Updated 31 test fixtures in totalaccountwatcher_test.go
- Regenerated CRDs, mocks, and OpenAPI schema

The new State field provides the same functionality with additional
states (PENDING_ACTIVATION, CLOSED) for better account lifecycle management.

Ref: SREP-1856

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@openshift-ci openshift-ci Bot requested review from eth1030 and luis-falcon March 19, 2026 20:49
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.40%. Comparing base (a9b9d10) to head (21818d9).
⚠️ Report is 13 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #958      +/-   ##
==========================================
+ Coverage   46.38%   46.40%   +0.01%     
==========================================
  Files          46       46              
  Lines        6812     6814       +2     
==========================================
+ Hits         3160     3162       +2     
  Misses       3319     3319              
  Partials      333      333              
Files with missing lines Coverage Δ
pkg/totalaccountwatcher/totalaccountwatcher.go 63.39% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AlexSmithGH
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 24, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexSmithGH, BATMAN-JD

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 24, 2026

@BATMAN-JD: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 4fcfdb9 into openshift:master Mar 24, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants