SRVKP-11391: fix for archived PLR details page

[arvindk-softwaredev]

Summary

Updated logic for archived PipelineRun loader to prevent indefinite loading state

Fix

Changed the loaded condition from && (AND) to || (OR) across three components so that the UI considers data loaded when either source has finished loading:

• PipelineRunDetailsPage.tsx — pipelineRunLoaded = k8sLoaded || trLoaded (was &&)

• PipelineRunVisualization.tsx — taskRunsLoaded = k8sLoaded || trLoaded (was &&)

• PipelineRunLogs.tsx — Destructured k8sLoaded and trLoaded separately from useTaskRuns (previously collapsed into a single taskRunsLoaded), then applied the same || logic to compute taskRunsLoaded

This ensures that if at least one data source (K8s or Tekton Results) has completed loading, the UI will render the available data instead of blocking indefinitely.

Screen Recordings

Before

SRVKP-11391-Before.mov

After Fix

SRVKP-11391-After.mov

[openshift-ci-robot]

@arvindk-softwaredev: This pull request references SRVKP-11393 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Summary

Updated logic for archived PipelineRun loader to prevent indefinite loading state

Fix

Changed the loaded condition from && (AND) to || (OR) across three components so that the UI considers data loaded when either source has finished loading:

• PipelineRunDetailsPage.tsx — pipelineRunLoaded = k8sLoaded || trLoaded (was &&)

• PipelineRunVisualization.tsx — taskRunsLoaded = k8sLoaded || trLoaded (was &&)

• PipelineRunLogs.tsx — Destructured k8sLoaded and trLoaded separately from useTaskRuns (previously collapsed into a single taskRunsLoaded), then applied the same || logic to compute taskRunsLoaded

This ensures that if at least one data source (K8s or Tekton Results) has completed loading, the UI will render the available data instead of blocking indefinitely.

Screen Recordings

Before

SRVKP-11391-Before.mov

After Fix

SRVKP-11391-After.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@arvindk-softwaredev: This pull request references SRVKP-11391 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Summary

Updated logic for archived PipelineRun loader to prevent indefinite loading state

Fix

Changed the loaded condition from && (AND) to || (OR) across three components so that the UI considers data loaded when either source has finished loading:

• PipelineRunDetailsPage.tsx — pipelineRunLoaded = k8sLoaded || trLoaded (was &&)

• PipelineRunVisualization.tsx — taskRunsLoaded = k8sLoaded || trLoaded (was &&)

• PipelineRunLogs.tsx — Destructured k8sLoaded and trLoaded separately from useTaskRuns (previously collapsed into a single taskRunsLoaded), then applied the same || logic to compute taskRunsLoaded

This ensures that if at least one data source (K8s or Tekton Results) has completed loading, the UI will render the available data instead of blocking indefinitely.

Screen Recordings

Before

SRVKP-11391-Before.mov

After Fix

SRVKP-11391-After.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[anwesha-palit-redhat]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anwesha-palit-redhat, arvindk-softwaredev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [anwesha-palit-redhat,arvindk-softwaredev]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment